polish/fix: read (fetch) hasTime in date property

- refactor 'isset' to Arr::exists
- evaluate if time is included, based on 'T' in datetime-string (when reading a date property from Notion)
- allow return of null within ->getEnd() getter (allow same in RichDate::class)
- add ->hasTime() getter, which calls ->hasTime() from RichDate::class (content)
- refactor ->getHasTime() from RichDate::class to ->hasTime()

Author: johguentner

src/Entities/Properties/Date.php

@@ -6,6 +6,7 @@
 use FiveamCode\LaravelNotionApi\Entities\Contracts\Modifiable;
 use FiveamCode\LaravelNotionApi\Entities\PropertyItems\RichDate;
 use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
+use Illuminate\Support\Arr;
 
 /**
  * Class Date.
@@ -90,19 +91,26 @@ protected function fillDate(): void
     {
         $richDate = new RichDate();
 
-        if (isset($this->rawContent['start'])) {
+        if (Arr::exists($this->rawContent, 'start')) {
             $startAsIsoString = $this->rawContent['start'];
             $richDate->setStart(new DateTime($startAsIsoString));
+            $richDate->setHasTime($this->isIsoTimeString($startAsIsoString));
         }
 
-        if (isset($this->rawContent['end'])) {
+        if (Arr::exists($this->rawContent, 'end')) {
             $endAsIsoString = $this->rawContent['end'];
             $richDate->setEnd(new DateTime($endAsIsoString));
         }
 
         $this->content = $richDate;
     }
 
+    // function for checking if ISO datetime string includes time or not
+    private function isIsoTimeString(string $isoTimeDateString): bool
+    {
+        return strpos($isoTimeDateString, 'T') !== false;
+    }
+
     /**
      * @return RichDate
      */
@@ -128,10 +136,18 @@ public function getStart(): DateTime
     }
 
     /**
-     * @return DateTime
+     * @return ?DateTime
      */
-    public function getEnd(): DateTime
+    public function getEnd(): ?DateTime
     {
         return $this->getContent()->getEnd();
     }
+
+    /**
+     * @return bool
+     */
+    public function hasTime(): bool
+    {
+        return $this->getContent()->hasTime();
+    }
 }

src/Entities/PropertyItems/RichDate.php

@@ -61,7 +61,7 @@ public function getStart(): ?DateTime
     }
 
     /**
-     * @return DateTime
+     * @return ?DateTime
      */
     public function getEnd(): ?DateTime
     {
@@ -71,7 +71,7 @@ public function getEnd(): ?DateTime
     /**
      * @return bool
      */
-    public function getHasTime(): bool
+    public function hasTime(): bool
     {
         return $this->hasTime;
     }