Skip to content

Replace com.github.cerveada:scalatest-maven-plugin fork with mainstream org.scalatest:scalatest-maven-plugin #21

Description

@miroslavpojer

Background

root-pom pins com.github.cerveada:scalatest-maven-plugin:2.0.1 in two places:

  • <pluginManagement> — the version every consumer inherits
  • the code-coverage profile — where the JaCoCo agent argLine is wired into it

com.github.cerveada:scalatest-maven-plugin is a JitPack fork of an old
org.scalatest:scalatest-maven-plugin. It differs from mainstream by a single commit,
cerveada/scalatest-maven-plugin@e16f1c5,
which fixed JVM path references for forked test runs.

History:

From AbsaOSS/commons#147:

"It was done quite a while ago and I'm not sure if it's still needed. It is worth checking if
things are working fine with a mainstream branch of the scalatest." — @wajda

Why now

The JMF adoption work (#2, AbsaOSS/commons#144) rewires the JaCoCo agent argLine in the
code-coverage profile. That wiring should target one mainstream ScalaTest plugin, not a fork.
Doing this first keeps the JMF root-pom change clean and avoids carrying the fork into the new
root-pom major release.

Goal

Remove the cerveada fork from root-pom; standardize on mainstream org.scalatest:scalatest-maven-plugin.

Scope

  • <pluginManagement>: replace com.github.cerveada:scalatest-maven-plugin:2.0.1 with
    org.scalatest:scalatest-maven-plugin:<latest release>.
  • code-coverage profile: move the <argLine> wiring from the com.github.cerveada plugin
    block to the org.scalatest one.
  • Remove the JitPack <repository> / <pluginRepository> entry if it exists solely for this fork.
  • Regression check: reproduce the original A wrong java version is used for running unit-tests commons#52 scenario (forked test JVM,
    non-default / multiple JDKs) and confirm the "wrong Java version" bug does not return.
  • Build + test with mvn clean verify and mvn clean verify -Pcode-coverage against at least
    two root-pom consumers (Commons + one other Maven project).
  • Grep the AbsaOSS org for direct references to com.github.cerveada; list affected repos.
  • Release note: no action for consumers unless they explicitly referenced the cerveada groupId.

Risks & mitigations

Risk Mitigation
The fork's JVM-path fix is still needed on some CI setup The regression check above. If reproduced, raise a PR against mainstream scalatest-maven-plugin or keep a documented pin with a linked upstream issue.
Other consumers reference com.github.cerveada directly Org-wide grep; call out in release notes; coordinate bumps.
Behaviour change between cerveada 2.0.x and latest mainstream Diff the changelog; run the full test suites of both test consumers.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions