Balance Platform: remove DeviceInfo attributes

[gcatanese]

PR to generate the BalancePlatform models:

• remove DeviceInfo fields: cardCaptureTechnology, deviceName, imei, isoDeviceType, msisdn, osVersion, paymentTypes, serialNumber, storageTechnology
• in Balance add pendingAvailable attribute
• in BulkAddress add name attribute
• in CreateSweepConfigurationV2 and UpdateSweepConfigurationV2 add enum ReasonEnum.SCHEMEADVICE

All models have been updated to handle the nullable value (Mustache templates have been updated as part of #1603)

[gemini-code-assist]

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the clarity and control of Balance Platform models. It cleans up the DeviceInfo model by removing obsolete fields and introduces a new pendingAvailable field in the Balance model. Crucially, it integrates a new serialization pattern across many models, allowing developers to explicitly indicate when a field's null value should be included in the JSON output, which is vital for distinguishing between unset and intentionally nullified data.

Highlights

• Model Refinement: Removed several unused or deprecated attributes from the DeviceInfo model to streamline its structure.
• New Balance Attribute: Added a new pendingAvailable attribute to the Balance model, enhancing the information available for balance tracking.
• Explicit Null Serialization: Implemented a mechanism across numerous Balance Platform models to explicitly serialize null values in JSON payloads, providing more precise control over API requests and responses. This involves adding isSet flags for each attribute and a global includeNullValues flag.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a mechanism for explicit null serialization across numerous model classes by adding isSet... flags and a getExplicitNulls method. This is a significant but consistent change that appears to be correctly implemented. The PR also removes several fields from the DeviceInfo model and adds a pendingAvailable field to the Balance model, aligning with the description. My main feedback concerns the significant code duplication introduced by the new null-handling mechanism, which I've detailed in a specific comment.

I am having trouble creating individual review comments. Click here to see my feedback.

src/main/java/com/adyen/model/balanceplatform/AULocalAccountIdentification.java (294-298)

This helper method addIfNull and the associated logic for explicit null serialization (including getExplicitNulls, isSet... flags, and includeNullValues logic) are duplicated across many model classes in this pull request. This extensive code duplication can make future maintenance more difficult and error-prone.

Since this code appears to be generated from templates, I recommend refactoring the templates to extract this common functionality into a shared base class. This would make the generated model classes much cleaner and easier to maintain.

A base class could manage the includeNullValues flag and the logic for collecting and serializing null fields, reducing the boilerplate in each subclass.

src/main/java/com/adyen/model/balanceplatform/Balance.java (222-249)

The Javadoc for the new pendingAvailable field and its accessor methods is incomplete. Please add a description for this field to clarify its purpose.

src/main/java/com/adyen/model/balanceplatform/BulkAddress.java (93-97)

The new name field is a good addition for bulk addresses. The implementation is consistent with the other fields in the class.

src/main/java/com/adyen/model/balanceplatform/CreateSweepConfigurationV2.java (225)

The addition of SCHEMEADVICE to the ReasonEnum is noted. Ensure that all systems handling this enum are updated to recognize this new value.

src/main/java/com/adyen/model/balanceplatform/DeviceInfo.java (23-35)

The removal of several fields from DeviceInfo simplifies the model as described in the pull request. The remaining fields and their updated Javadoc look correct.