Skip to content

feat: support Grok Build CLI through ACP #41

Description

@EmersonBraun

Parent

#37

What to build

Add the first-class grok-cli provider using Grok Build's ACP stdio mode (grok agent stdio). The adapter must behave as one bounded worker for one review lens and translate a valid schemaVersion: 1 JSON response into the existing AgentsKit tool-call stream.

Acceptance criteria

  • --provider grok-cli resolves through the provider registry without changing --provider grok API behavior.
  • ACP initialize/session/prompt/update/shutdown lifecycle is implemented with bounded timeouts and cancellation.
  • The adapter requests one lens result and never delegates lens selection, verification, consolidation, or reporting to Grok.
  • The adapter accepts only the versioned JSON envelope and validates the expected Finding schema before emitting a tool call.
  • One bounded retry is allowed only for empty/malformed/schema-invalid output.
  • Filesystem write, terminal, MCP, plugin, and subagent capabilities are not granted in isolated mode.
  • trusted-local may reuse the user's Grok configuration but remains a worker-only review path and cannot write the real checkout.
  • Model selection, data boundary, redaction, and effective version appear in diagnostics without secrets.
  • Offline ACP fixtures cover successful output, malformed output, timeout, cancellation, permission request, tool-attempt rejection, and process failure.
  • The provider is not marked stable until all offline contract tests pass.

Blocked by

Files and references

Notes

Do not install Grok automatically. The Action must fail early with a doctor-style message when the executable is absent.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions