From d40787946dace62da0d2ff737c4216d2a78cb387 Mon Sep 17 00:00:00 2001 From: Yusuke Asai Date: Sun, 14 Sep 2025 11:58:06 +0900 Subject: [PATCH 1/2] remove unnecessary check --- internal/syntax/syntax_node_identifier_child_multi.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/internal/syntax/syntax_node_identifier_child_multi.go b/internal/syntax/syntax_node_identifier_child_multi.go index 040c41e..8a35b40 100644 --- a/internal/syntax/syntax_node_identifier_child_multi.go +++ b/internal/syntax/syntax_node_identifier_child_multi.go @@ -37,12 +37,6 @@ func (i *syntaxChildMultiIdentifier) retrieveMap( var deepestError errors.ErrorRuntime for _, identifier := range i.identifiers { - if singleIdentifier, ok := identifier.(*syntaxChildSingleIdentifier); ok { - if _, ok = srcMap[singleIdentifier.identifier]; !ok { - continue - } - } - if err := identifier.retrieve(root, srcMap, results); len(*results) == 0 && err != nil { deepestError = i.getMostResolvedError(err, deepestError) } From bcb9b37e58eb7e8054aa812aabb355d1ba9b80c4 Mon Sep 17 00:00:00 2001 From: Yusuke Asai Date: Sun, 14 Sep 2025 12:07:45 +0900 Subject: [PATCH 2/2] move ignorable error check inside the error-handling block --- internal/syntax/syntax_node_identifier_child_multi.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/internal/syntax/syntax_node_identifier_child_multi.go b/internal/syntax/syntax_node_identifier_child_multi.go index 8a35b40..72c8553 100644 --- a/internal/syntax/syntax_node_identifier_child_multi.go +++ b/internal/syntax/syntax_node_identifier_child_multi.go @@ -38,6 +38,11 @@ func (i *syntaxChildMultiIdentifier) retrieveMap( for _, identifier := range i.identifiers { if err := identifier.retrieve(root, srcMap, results); len(*results) == 0 && err != nil { + if singleIdentifier, ok := identifier.(*syntaxChildSingleIdentifier); ok { + if _, ok = srcMap[singleIdentifier.identifier]; !ok { + continue + } + } deepestError = i.getMostResolvedError(err, deepestError) } }