General formatting and cleanup (#1844)

Author: hyperxpro

client/src/main/java/org/asynchttpclient/AsyncHttpClientConfig.java

@@ -230,7 +230,7 @@ public interface AsyncHttpClientConfig {
      * In the case of a POST/Redirect/Get scenario where the server uses a 302 for the redirect, should AHC respond to the redirect with a GET or whatever the original method was.
      * Unless configured otherwise, for a 302, AHC, will use a GET for this case.
      *
-     * @return <code>true</code> if strict 302 handling is to be used, otherwise {@code false}.
+     * @return {@code true} if strict 302 handling is to be used, otherwise {@code false}.
      */
     boolean isStrict302Handling();
 

client/src/main/java/org/asynchttpclient/RequestBuilderBase.java

@@ -15,7 +15,6 @@
  */
 package org.asynchttpclient;
 
-import io.netty.buffer.ByteBuf;
 import io.netty.handler.codec.http.DefaultHttpHeaders;
 import io.netty.handler.codec.http.HttpHeaders;
 import io.netty.handler.codec.http.cookie.Cookie;
@@ -57,7 +56,7 @@ public abstract class RequestBuilderBase<T extends RequestBuilderBase<T>> {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(RequestBuilderBase.class);
     private static final Uri DEFAULT_REQUEST_URL = Uri.create("http://localhost");
-    public static NameResolver<InetAddress> DEFAULT_NAME_RESOLVER = new DefaultNameResolver(ImmediateEventExecutor.INSTANCE);
+    public static final NameResolver<InetAddress> DEFAULT_NAME_RESOLVER = new DefaultNameResolver(ImmediateEventExecutor.INSTANCE);
     // builder only fields
     protected UriEncoder uriEncoder;
     protected List<Param> queryParams;

client/src/main/java/org/asynchttpclient/channel/DefaultKeepAliveStrategy.java

@@ -30,7 +30,7 @@
 public class DefaultKeepAliveStrategy implements KeepAliveStrategy {
 
     /**
-     * Implemented in accordance with RFC 7230 section 6.1 https://tools.ietf.org/html/rfc7230#section-6.1
+     * Implemented in accordance with RFC 7230 section 6.1 <a href="https://tools.ietf.org/html/rfc7230#section-6.1">...</a>
      */
     @Override
     public boolean keepAlive(InetSocketAddress remoteAddress, Request ahcRequest, HttpRequest request, HttpResponse response) {

client/src/main/java/org/asynchttpclient/filter/ReleasePermitOnComplete.java

@@ -71,6 +71,6 @@ private static Class<?>[] allInterfaces(Class<?> handlerClass) {
         for (Class<?> clazz = handlerClass; clazz != null; clazz = clazz.getSuperclass()) {
             Collections.addAll(allInterfaces, clazz.getInterfaces());
         }
-        return allInterfaces.toArray(new Class[allInterfaces.size()]);
+        return allInterfaces.toArray(new Class[0]);
     }
 }

client/src/main/java/org/asynchttpclient/handler/BodyDeferringAsyncHandler.java

@@ -49,7 +49,7 @@
  *     OutputStream fos = ...
  *     BodyDeferringAsyncHandler bdah = new BodyDeferringAsyncHandler(fos);
  *     // client executes async
- *     Future<Response> fr = client.prepareGet("http://foo.com/aresource").execute(
+ *     Future&lt;Response&gt; fr = client.prepareGet(&quot;<a href="http://foo.com/aresource&quot;">...</a>).execute(
  * 	bdah);
  *     // main thread will block here until headers are available
  *     Response response = bdah.getResponse();

client/src/main/java/org/asynchttpclient/netty/future/StackTraceInspector.java

@@ -37,8 +37,11 @@ private static boolean exceptionInMethod(Throwable t, String className, String m
     }
 
     private static boolean recoverOnConnectCloseException(Throwable t) {
-        return exceptionInMethod(t, "sun.nio.ch.SocketChannelImpl", "checkConnect")
-                || t.getCause() != null && recoverOnConnectCloseException(t.getCause());
+        while (true) {
+            if (exceptionInMethod(t, "sun.nio.ch.SocketChannelImpl", "checkConnect")) return true;
+            if (t.getCause() == null) return false;
+            t = t.getCause();
+        }
     }
 
     public static boolean recoverOnNettyDisconnectException(Throwable t) {
@@ -48,21 +51,24 @@ public static boolean recoverOnNettyDisconnectException(Throwable t) {
     }
 
     public static boolean recoverOnReadOrWriteException(Throwable t) {
-        if (t instanceof IOException && "Connection reset by peer".equalsIgnoreCase(t.getMessage())) {
-            return true;
-        }
+        while (true) {
+            if (t instanceof IOException && "Connection reset by peer".equalsIgnoreCase(t.getMessage())) {
+                return true;
+            }
 
-        try {
-            for (StackTraceElement element : t.getStackTrace()) {
-                String className = element.getClassName();
-                String methodName = element.getMethodName();
-                if ("sun.nio.ch.SocketDispatcher".equals(className) && ("read".equals(methodName) || "write".equals(methodName))) {
-                    return true;
+            try {
+                for (StackTraceElement element : t.getStackTrace()) {
+                    String className = element.getClassName();
+                    String methodName = element.getMethodName();
+                    if ("sun.nio.ch.SocketDispatcher".equals(className) && ("read".equals(methodName) || "write".equals(methodName))) {
+                        return true;
+                    }
                 }
+            } catch (Throwable ignore) {
             }
-        } catch (Throwable ignore) {
-        }
 
-        return t.getCause() != null && recoverOnReadOrWriteException(t.getCause());
+            if (t.getCause() == null) return false;
+            t = t.getCause();
+        }
     }
 }

client/src/main/java/org/asynchttpclient/netty/handler/AsyncHttpClientHandler.java

@@ -15,16 +15,13 @@
  */
 package org.asynchttpclient.netty.handler;
 
-import io.netty.buffer.ByteBuf;
 import io.netty.channel.Channel;
 import io.netty.channel.ChannelHandlerContext;
 import io.netty.channel.ChannelInboundHandlerAdapter;
 import io.netty.handler.codec.PrematureChannelClosureException;
-import io.netty.handler.codec.http.HttpContent;
 import io.netty.handler.codec.http.LastHttpContent;
 import io.netty.util.ReferenceCountUtil;
 import org.asynchttpclient.AsyncHttpClientConfig;
-import org.asynchttpclient.HttpResponseBodyPart;
 import org.asynchttpclient.exception.ChannelClosedException;
 import org.asynchttpclient.netty.DiscardEvent;
 import org.asynchttpclient.netty.NettyResponseFuture;

client/src/main/java/org/asynchttpclient/netty/handler/intercept/ProxyUnauthorized407Interceptor.java

@@ -144,7 +144,6 @@ public boolean exitAfterHandling407(Channel channel, NettyResponseFuture<?> futu
                 try {
                     kerberosProxyChallenge(proxyRealm, proxyServer, requestHeaders);
                 } catch (SpnegoEngineException e) {
-                    // FIXME
                     String ntlmHeader2 = getHeaderWithPrefix(proxyAuthHeaders, "NTLM");
                     if (ntlmHeader2 != null) {
                         LOGGER.warn("Kerberos/Spnego proxy auth failed, proceeding with NTLM");

client/src/main/java/org/asynchttpclient/netty/handler/intercept/Unauthorized401Interceptor.java

@@ -139,9 +139,7 @@ public boolean exitAfterHandling401(Channel channel, NettyResponseFuture<?> futu
                 }
                 try {
                     kerberosChallenge(realm, request, requestHeaders);
-
                 } catch (SpnegoEngineException e) {
-                    // FIXME
                     String ntlmHeader2 = getHeaderWithPrefix(wwwAuthHeaders, "NTLM");
                     if (ntlmHeader2 != null) {
                         LOGGER.warn("Kerberos/Spnego auth failed, proceeding with NTLM");