Better to add timeout/interval to the Instruction class instead of ConditionWatcher?

[hkmushtaq]

I think it makes more sense to make the interval/timeout be instruction specific then be on on the main ConditionWatcher class.

We can keep defaults but I feel like its safer for the defaults to reside in Instruction

I'm also willing to make the PR for it.
Thoughts?

[polok]

You have 👍 from me :)

[FisherKK]

Hey @hkmushtaq

Sounds not bad I think.
Usually I created wrapping code around my ConditionWatcher's waitForCondition method. It resulted in even 15+ variations of something like this:

    public void waitForCondition(String key, int waitTimeInMs, int interval, Bundle data) throws Exception {
        Instruction instruction = InstructionStore.getInstructionForKey(key);
        instruction.setData(data);
        ConditionWatcher.setTimeoutLimit(waitTimeInMs);
        ConditionWatcher.setWatchInterval(interval);
        ConditionWatcher.waitForCondition(instruction);
        ConditionWatcher.setWatchInterval(ConditionWatcher.DEFAULT_INTERVAL);
    }

Your idea could reduce it so I think it's a good direction. Go ahead with PR, I will be happy to check and merge it :)

[hkmushtaq]

Awesome, I'll get to work on refactoring it!