From 7e741cc47b0ced18bd2884e64320a2e19523a727 Mon Sep 17 00:00:00 2001 From: Yalin Li Date: Sun, 31 May 2026 06:50:58 -0400 Subject: [PATCH 1/2] fix system convergence tolerance bug --- biosteam/_system.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/biosteam/_system.py b/biosteam/_system.py index 95df082a..0fb9a54e 100644 --- a/biosteam/_system.py +++ b/biosteam/_system.py @@ -1493,7 +1493,7 @@ def set_tolerance(self, mol: Optional[float]=None, rmol: Optional[float]=None, """ if mol is not None: self.molar_tolerance = float(mol) if rmol is not None: self.relative_molar_tolerance = float(rmol) - if T is not None: self.temperature_tolerance = float(T) + if T is not None: self.relative_temperature_tolerance = float(T) if rT is not None: self.temperature_tolerance = float(rT) if maxiter is not None: self.maxiter = int(maxiter) if method is not None: self.method = method From b568c1458284a9401acedaf24cbeebbe52414265 Mon Sep 17 00:00:00 2001 From: Yalin Li Date: Sun, 31 May 2026 06:52:28 -0400 Subject: [PATCH 2/2] implement the correct fix --- biosteam/_system.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/biosteam/_system.py b/biosteam/_system.py index 0fb9a54e..df9fd952 100644 --- a/biosteam/_system.py +++ b/biosteam/_system.py @@ -1493,8 +1493,8 @@ def set_tolerance(self, mol: Optional[float]=None, rmol: Optional[float]=None, """ if mol is not None: self.molar_tolerance = float(mol) if rmol is not None: self.relative_molar_tolerance = float(rmol) - if T is not None: self.relative_temperature_tolerance = float(T) - if rT is not None: self.temperature_tolerance = float(rT) + if T is not None: self.temperature_tolerance = float(T) + if rT is not None: self.relative_temperature_tolerance = float(rT) if maxiter is not None: self.maxiter = int(maxiter) if method is not None: self.method = method if algorithm is not None: self.algorithm = algorithm