[Feature]: add a way to keep using the plugin without flight

[Bishops-exe]

Summary

Add a way to keep using the plugin without flight

Problem This Solves

Currently, users of my own plugin cannot use it, when flight is disabled. But the player in my plugin interacts or stands on top of the block.

Proposed Solution

remove line 54 in PacketBlocks.java

Alternatives Considered

You could also add a config file, where the user can acknowledge the warning

Additional Context

No response

Priority

Medium – helpful improvement

[BitByLogics]

The problem is if that setting isn't disabled players will be kicked for "flying" when standing on any packet blocks. I could just cancel the kick event over and over again however that solution isn't ideal as I'd rather not spam event calls.

[Bishops-exe]

I dont think you've understood the point of this issue. I think the plugin should not disable itself because of that. The user should be responsible for reading the warning

[BitByLogics]

If the plugin doesn't disable itself then players will be kicked for standing on packet blocks. I'd rather disable the plugin with a very clear warning, than leave it functional but have players be kicked without any clear reason (warning message wise).

Can you elaborate more on how this impacts your plugin?

[Bishops-exe]

But i think there should still be a way to keep the plugin running while allow flight is off

[Bishops-exe]

What do you think of the alternative solution?

[BitByLogics]

I'll be implementing the kick event cancelling, and implementing PaperMC/Paper#14016 if approved.

[Bishops-exe]

Why not use reflection, if you use the paper api, it will break spigot and bukkit support.
Can you try this out. i havent tested it

public class ResetFlyingTicks {
    public static void resetFlyingTicks(Player player) {
        try {
            Class<?> craftPlayerClass = Class.forName("org.bukkit.craftbukkit.entity.CraftPlayer");
            boolean isCraftPlayer = craftPlayerClass.isInstance(player);
            if (!isCraftPlayer) {
                throw new RuntimeException("Unexpected Type! Expected org.bukkit.craftbukkit.entity.CraftPlayer");
            }

            Method getHandleMethod = craftPlayerClass.getDeclaredMethod("getHandle");
            getHandleMethod.setAccessible(true);
            Object serverPlayer = getHandleMethod.invoke(player);

            Class<?> serverPlayerClass = Class.forName("net.minecraft.server.level.ServerPlayer");
            boolean isServerPlayer = serverPlayerClass.isInstance(serverPlayer);
            if (!isServerPlayer) {
                throw new RuntimeException("Unexpected Type! Expected net.minecraft.server.level.ServerPlayer");
            }

            Field connectionField = serverPlayerClass.getDeclaredField("connection");
            connectionField.setAccessible(true);
            Object connection = connectionField.get(serverPlayer);

            Class<?> connectionClass = Class.forName("net.minecraft.network.protocol.game.ServerGamePacketListenerImpl");
            boolean isConnection = connectionClass.isInstance(connection);
            if (!isConnection) {
                throw new RuntimeException("Unexpected Type! Expected net.minecraft.network.protocol.game.ServerGamePacketListenerImpl");
            }

            Method resetFlyingTicksMethod = connectionClass.getDeclaredMethod("resetFlyingTicks");
            resetFlyingTicksMethod.setAccessible(true);
            resetFlyingTicksMethod.invoke(connection);
        } catch (ClassNotFoundException | NoSuchMethodException | InvocationTargetException | IllegalAccessException | NoSuchFieldException e) {
            throw new RuntimeException(e);
        }

    }
}

[Bishops-exe]

If you get that pr merged, you should first check to see if that function is available otherwise fallback to the example

[BitByLogics]

Unfortunately, I won't be using any NMS/Reflection in this API. I'm also not concerned about support for Spigot/Bukkit as the majority of servers are running Paper and/or a Paper fork. I want to keep this lib maintainable, and backporting it or supporting severely outdated versions is not that. However that being said, if the method doesn't exist on the servers version (assuming PacketBlocks supports it) it'll just cancel the event without resetting the fly ticks.