"Run Query" appears in context menu for non-SQL files

[Balearica]

I added this function to help with a handful of .sql files in my repo. However, now whenever I highlight anything the top option in the context menu is Run Query. For example, the following happens when I highlight and right-click a JavaScript function in a .js file.

I am connected to a Postgres database, and everything works correctly when I'm actually in a SQL file. I reviewed the settings for this extension and didn't see anything applicable.

Would appreciate a fix if others have figured this out. Additionally, if this is the default behavior and not something I somehow caused myself, I think it should be changed. I don't see any reason why a Postgres extension should impact the context menu in .js files by default.

[Balearica]

It looks like this behavior is indeed intended and hard-coded--Run Query is added to the menu when any contents of any file is highlighted.

vscode-postgres/package.json

Lines 288 to 292 in 88ec5ed

	{
	"command": "vscode-postgres.runQuery",
	"when": "editorLangId != postgres && editorHasSelection && !editorHasMultipleSelections",
	"group": "navigation"
	},

I think this is over-aggressive for a default behavior, and I don't see why this condition is needed at all. VSCode already contains features for associated file extensions with languages, so if certain users want to use some weird extension for their SQL queries, they can set that option. If nothing else, there should be an option to easily disable this, which there does not appear to be.

I'm happy to help contribute a fix if somebody with maintainer access chimes in with how they think this should be handled. I am currently hesitant to devote the time as (1) I'm unsure why this was added in the first place and (2) it looks like nothing has been merged into master in multiple years.

[Borvik]

It was indeed intentionally done from the beginning. I wanted the ability as I write code and came across SQL in my code files, that I could execute it right from there rather than copy-pasting it to a separate file.

[Balearica]

@Borvik Thanks for explaining. I can see how for projects that use SQL more expansively that could be useful; in my project SQL is never called directly from other languages, and the .sql files only exist in a dev directory. If I create a PR that adds an option for disabling the postgres commands when editorLangId != postgres, would you merge that in? This would improve the experience for anybody using the extension for more limited purposes, such as reviewing logs. The default behavior would stay the same.