fix(release): only fix/feat/perf commits can cut a release

The chore(scope) release gating added for catalog syncs made the post-release 'chore(release): sync manifests' merge releasable (it touches package.json/manifest.json), so every release spawned the next one in an infinite loop (0.7.5..0.7.36+). Restore fix/feat/perf-only subject matching: manifest-sync and catalog-sync chore commits are bookkeeping and never release.

Author: BrainerVirus

scripts/analyze-release-scope.ts

@@ -31,18 +31,19 @@ export function latestTag(root = process.cwd()): string | null {
 
 type Level = "major" | "minor" | "patch";
 const LEVEL_RANK: Record<Level, number> = { patch: 1, minor: 2, major: 3 };
-// "chore(scope)" covers routine product refreshes that still ship (e.g.
-// chore(catalog): sync models.json); "chore" without a scope stays inert.
+// Releasable types only. "chore" (including chore(scope) like chore(release):
+// sync manifests or chore(catalog)) is bookkeeping and must never cut a
+// release — otherwise the post-release manifest-sync merge re-releases and
+// loops forever.
 const TYPE_LEVEL: Record<string, Level> = { fix: "patch", perf: "patch", feat: "minor" };
 
 const subjectLevel = (commit: string): Level | null => {
   const firstLine = commit.split("\n")[0] ?? "";
-  const m = /^(?:(?:fix|perf|feat)|chore\([^)]*\))(?:\([^)]*\))?!?:/.exec(firstLine);
+  const m = /^(?:fix|perf|feat)(?:\([^)]*\))?!?:/.exec(firstLine);
   if (!m) return null;
   if (m[0].includes("!")) return "major";
   const body = commit.split("\n").slice(1).join("\n");
   const type = m[0].replace(/\(.*$/, "").replace(/!$/, "").replace(/:$/, "");
-  if (type === "chore") return "patch";
   return /BREAKING[- ]CHANGE:/.test(body) ? "major" : (TYPE_LEVEL[type] ?? null);
 };
 

tests/unit/analyze-release-scope.test.ts

@@ -109,26 +109,15 @@ describe("analyzeReleaseScope", () => {
     }
   });
 
-  test("chore(scope) commits that only touch non-product files yield no release", () => {
+  test("chore(scope) commits never yield a release even when they touch product files", () => {
     const r = repo();
     r.tag("v0.6.0");
     try {
-      r.commit("chore(catalog): tweak CI", { ".github/workflows/catalog-sync.yml": "cron: 0 *\n" });
+      r.commit("chore(catalog): sync command-code@1.40.1", { "models.json": "[]\n" });
+      r.commit("chore(release): sync manifests to v0.7.5", { "package.json": "{}" });
       expect(analyzeReleaseScope(r.root)).toEqual({ level: null });
     } finally {
       r.cleanup();
     }
   });
-
-  test("chore(scope) with product-file change still releases at patch", () => {
-    const r = repo();
-    r.tag("v0.6.0");
-    try {
-      r.commit("chore(catalog): refresh", { "models.json": "[]\n" });
-      // prod file touched + chore(scope): treat as the scope's default patch release
-      expect(analyzeReleaseScope(r.root).level).toBe("patch");
-    } finally {
-      r.cleanup();
-    }
-  });
 });