fix: restore TTY cleanup for stream interrupts#175
Open
luyua9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the streaming interrupt key path in
readData():q/escape,finallywhen the stream exits.Without
readline.emitKeypressEvents(), thekeypresslistener is not reliably wired for raw stdin, so the documented stop keys can fail while the terminal is left in raw mode after early stream exit.Validation
git diff --checknpm run typecheck -- --pretty falsecould not run in this clean checkout because dependencies are not installed (Cannot find module 'cleye',openai,@types/node, etc.).