Skip to content

Commit 01c70a5

Browse files
committed
fix radio group. Replace label with fieldset/legent & change readme
1 parent 2cbff6d commit 01c70a5

2 files changed

Lines changed: 32 additions & 31 deletions

File tree

Form-Controls/README.md

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44

55
<!--{{<objectives>}}>-->
66

7-
- [ ] Interpret requirements and check against a list of criteria
8-
- [ ] Write a valid form
9-
- [ ] Test with Devtools
10-
- [ ] Refactor using Devtools
11-
- [ ] Use version control by committing often and pushing regularly to GitHub
12-
- [ ] Develop the habit of writing clean, well-structured, and error-free code
7+
- [x] Interpret requirements and check against a list of criteria
8+
- [x] Write a valid form
9+
- [x] Test with Devtools
10+
- [x] Refactor using Devtools
11+
- [x] Use version control by committing often and pushing regularly to GitHub
12+
- [x] Develop the habit of writing clean, well-structured, and error-free code
1313
<!--{{<objectives>}}>-->
1414

1515
## Task
@@ -34,18 +34,18 @@ Do not write a form action for this project.
3434

3535
Let's write out our testable criteria. Check each one off as you complete it.
3636

37-
- [ ] I have only used HTML and CSS.
38-
- [ ] I have not used any JavaScript.
37+
- [x] I have only used HTML and CSS.
38+
- [x] I have not used any JavaScript.
3939

4040
### HTML
4141

42-
- [ ] My form is semantic HTML.
43-
- [ ] All inputs have associated labels.
44-
- [ ] My Lighthouse Accessibility score is 100.
45-
- [ ] I require a valid name.
46-
- [ ] I require a valid email.
47-
- [ ] I require one colour from a defined set of 3 colours.
48-
- [ ] I require one size from a defined set of 6 sizes.
42+
- [x] My form is semantic HTML.
43+
- [x] All inputs have associated labels.
44+
- [x] My Lighthouse Accessibility score is 100.
45+
- [x] I require a valid name.
46+
- [x] I require a valid email.
47+
- [x] I require one colour from a defined set of 3 colours.
48+
- [x] I require one size from a defined set of 6 sizes.
4949

5050
### Developers must adhere to professional standards.
5151

@@ -54,10 +54,10 @@ Let's write out our testable criteria. Check each one off as you complete it.
5454
These practices reflect the level of quality expected in professional work.
5555
They ensure your code is reliable, maintainable, and presents a polished, credible experience to users.
5656

57-
- [ ] My HTML code has no errors or warnings when validated using https://validator.w3.org/
58-
- [ ] My code is consistently formatted
59-
- [ ] My page content is free of typos and grammatical mistakes
60-
- [ ] I commit often and push regularly to GitHub
57+
- [x] My HTML code has no errors or warnings when validated using https://validator.w3.org/
58+
- [x] My code is consistently formatted
59+
- [x] My page content is free of typos and grammatical mistakes
60+
- [x] I commit often and push regularly to GitHub
6161

6262
## Resources
6363
- [MDN: Form controls](https://developer.mozilla.org/en-US/docs/Learn/Forms)

Form-Controls/index.html

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -41,33 +41,34 @@ <h1>Verify your order </h1>
4141

4242
<!--T-shirt size -->
4343
<div id="sizeBox">
44-
<label for="size">T-shirt size:</label>
45-
46-
<div>
44+
<fieldset>
45+
<legend>T-shirt size:</legend>
46+
<div>
4747
<label for="very-small">XS</label>
4848
<input type="radio" id="very-small" name="size" value="very-small" required>
49-
</div>
50-
<div>
49+
</div>
50+
<div>
5151
<label for="small">S</label>
5252
<input type="radio" id="small" name="size" value="small" required>
53-
</div>
54-
<div>
53+
</div>
54+
<div>
5555
<label for="medium">M</label>
5656
<input type="radio" id="medium" name="size" value="medium" required>
57-
</div>
58-
<div>
57+
</div>
58+
<div>
5959
<label for="large">L</label>
6060
<input type="radio" id="large" name="size" value="large" required>
61-
</div>
62-
<div>
61+
</div>
62+
<div>
6363
<label for="very-large">XL</label>
6464
<input type="radio" id="very-large" name="size" value="very-large" required>
65+
</div>
66+
</fieldset>
6567
</div>
6668
<!--Submit button -->
6769
<div>
6870
<button type="submit">Submit</button>
6971
</div>
70-
</div>
7172
</form>
7273
</main>
7374
<footer>

0 commit comments

Comments
 (0)