Skip to content

Commit 4db1db6

Browse files
committed
Resolve merge conflict in Form-Controls index.html
2 parents 163d801 + c44123d commit 4db1db6

11 files changed

Lines changed: 167 additions & 295 deletions

File tree

.github/FUNDING.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,2 @@
1-
# These are supported funding model platforms
2-
31
github: CodeYourFuture
4-
patreon: # Replace with a single Patreon username
5-
open_collective: # Replace with a single Open Collective username
6-
ko_fi: # Replace with a single Ko-fi username
7-
tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
8-
community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
9-
liberapay: # Replace with a single Liberapay username
10-
issuehunt: # Replace with a single IssueHunt username
11-
otechie: # Replace with a single Otechie username
12-
lfx_crowdfunding: # Replace with a single LFX Crowdfunding project-name e.g., cloud-foundry
132
custom: https://codeyourfuture.io/donate

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 0 additions & 14 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/pd-assignment.yml

Lines changed: 0 additions & 59 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/tech-ed-assignment.yml

Lines changed: 0 additions & 88 deletions
This file was deleted.

.github/pull_request_template.md

Lines changed: 0 additions & 32 deletions
This file was deleted.
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
name: Validate PR Metadata
2+
on:
3+
pull_request_target:
4+
types:
5+
- labeled
6+
- unlabeled
7+
- opened
8+
- edited
9+
- reopened
10+
11+
jobs:
12+
validate_pr_metadata:
13+
runs-on: ubuntu-latest
14+
steps:
15+
- uses: actions/checkout@v4
16+
- uses: CodeYourFuture/actions/validate-pr-metadata@main
17+
with:
18+
give_more_specific_comment_for_earlier_learners: true
19+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Form-Controls/README.md

Lines changed: 32 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,44 +8,65 @@
88
- [ ] Write a valid form
99
- [ ] Test with Devtools
1010
- [ ] Refactor using Devtools
11+
- [ ] Use version control by committing often and pushing regularly to GitHub
12+
- [ ] Develop the habit of writing clean, well-structured, and error-free code
1113
<!--{{<objectives>}}>-->
1214

1315
## Task
1416

15-
We are selling t-shirts. Write a form to collect the following data:
17+
We are selling T-shirts. Write a form to collect the following data:
1618

1719
Our customers already have accounts, so we know their addresses and charging details already. We don't need to collect that data. We want to confirm they are the right person, then get them to choose a colour and size.
1820

1921
Writing that out as a series of questions to ask yourself:
2022

21-
1. What is the customer's name? I must collect this data, and validate it. But what is a valid name? I must decide something.
22-
2. What is the customer's email? I must make sure the email is valid. Email addresses have a consistent pattern.
23-
3. What colour should this t-shirt be? I must give 3 options. How will I make sure they don't pick other colours?
24-
4. What size does the customer want? I must give the following 6 options: XS, S, M, L, XL, XXL
23+
1. What is the customer's name? I must collect this data and ensure it contains at least two non-space characters.
24+
2. What is the customer's email? I must make sure the email is valid. Email addresses follow a consistent pattern.
25+
3. What colour should this T-shirt be? I must provide 3 options. How will I ensure they do not choose other colours?
26+
4. What size does the customer want? I must provide the following 6 options: XS, S, M, L, XL, XXL
2527

2628
All fields are required.
2729
Do not write a form action for this project.
2830

29-
## Developers must test their work.
31+
> [!TIP]
32+
> To check whether the customer's name contains at least two non-space characters you may need to use a **regular expression** (or **regex** for short), which is a tool used to match patterns in text. If you wish to learn more about regular expressions there are plenty of resources on the web including the [official MDN documentation](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_expressions), but for this task you can use this regex that we have pre-written for you: `.*\S.*\S.*`.
33+
>
34+
> Now you have the regular expression, it's up to you to figure out how to use it in the context of an HTML form!
35+
36+
## Acceptance Criteria
37+
38+
### Developers must test their work.
3039

3140
Let's write out our testable criteria. Check each one off as you complete it.
3241

33-
- [ ] I have used HTML only.
34-
- [x] I have not used any CSS or JavaScript.
42+
- [ ] I have only used HTML and CSS.
43+
- [ ] I have not used any JavaScript.
3544

3645
### HTML
3746

38-
- [ ] My form is semantic html.
47+
- [ ] My form is semantic HTML.
3948
- [ ] All inputs have associated labels.
4049
- [ ] My Lighthouse Accessibility score is 100.
41-
- [ ] I require a valid name. I have defined a valid name as a text string of two characters or more.
50+
- [ ] I require a valid name.
4251
- [ ] I require a valid email.
4352
- [ ] I require one colour from a defined set of 3 colours.
4453
- [ ] I require one size from a defined set of 6 sizes.
4554

46-
## Resources
55+
### Developers must adhere to professional standards.
56+
57+
> Before you say you're done: Is your code readable? Does it run correctly? Does it look professional?
4758
59+
These practices reflect the level of quality expected in professional work.
60+
They ensure your code is reliable, maintainable, and presents a polished, credible experience to users.
61+
62+
- [ ] My HTML code has no errors or warnings when validated using https://validator.w3.org/
63+
- [ ] My code is consistently formatted
64+
- [ ] My page content is free of typos and grammatical mistakes
65+
- [ ] I commit often and push regularly to GitHub
66+
67+
## Resources
4868
- [MDN: Form controls](https://developer.mozilla.org/en-US/docs/Learn/Forms)
4969
- [MDN: Form validation](https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation)
5070
- [Lighthouse](https://developers.google.com/web/tools/lighthouse)
5171
- [Lighthouse Guide](https://programming.codeyourfuture.io/guides/testing/lighthouse)
72+
- [Format Code and Make Logical Commits in VS Code](../practical_guide.md)

Form-Controls/index.html

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<!DOCTYPE html>
22
<html lang="en">
3+
<<<<<<< HEAD
34

45
<head>
56
<meta charset="utf-8" />
@@ -78,4 +79,30 @@ <h2>By Gideon Defar</h2>
7879
</footer>
7980
</body>
8081

82+
=======
83+
<head>
84+
<meta charset="utf-8" />
85+
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
86+
<title>My form exercise</title>
87+
<meta name="description" content="" />
88+
<meta name="viewport" content="width=device-width, initial-scale=1" />
89+
</head>
90+
<body>
91+
<header>
92+
<h1>Product Pick</h1>
93+
</header>
94+
<main>
95+
<form>
96+
<!-- write your html here-->
97+
<!--
98+
try writing out the requirements first as comments
99+
this will also help you fill in your PR message later-->
100+
</form>
101+
</main>
102+
<footer>
103+
<!-- change to your name-->
104+
<p>By HOMEWORK SOLUTION</p>
105+
</footer>
106+
</body>
107+
>>>>>>> c44123d682bd435b63f5494103678de8fb6bb371
81108
</html>

0 commit comments

Comments
 (0)