Skip to content

Commit 54c8432

Browse files
committed
refactor form structure for improved semantics and consistency
1 parent a49f4b6 commit 54c8432

1 file changed

Lines changed: 14 additions & 20 deletions

File tree

Form-Controls/index.html

Lines changed: 14 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -13,36 +13,30 @@
1313
<h1>T Shirt Order Form</h1>
1414
</div>
1515
<main class="main-content">
16-
<form>
17-
<form class="order-form">
18-
19-
16+
<form>
2017
<!-- Name Field -->
21-
<div class="form-group">
18+
<div class="form-inputs">
2219
<label for="name">Full Name</label>
23-
<input type="text" id="name" name="name" placeholder="John Robinson" required>
24-
</div>
25-
26-
<!-- Email Field -->
27-
<div class="form-group">
20+
<input type="text" id="name" name="name" required pattern =".*\S.*\S.*" placeholder="John Robinson">
21+
2822
<label for="email">Email Address</label>
29-
<input type="email" id="email" name="email" placeholder="john@example.com" required>
23+
<input type="email" id="email" name="email" required pattern="^[^\s@]+@[^\s@]+\.[^\s@]+$" placeholder="john@example.com">
3024
</div>
3125

3226
<!-- Shirt Colour 3 colours only-->
33-
<div class="form-group">
27+
<div class="form-selections">
3428
<label for="colour">T Shirt Colour</label>
35-
<select id="Colour" name="Colour">
29+
<select id="colour" name="colour">
3630
<option value="Red">Red</option>
3731
<option value="White">White</option>
3832
<option value="Black">Black</option>
3933
</select>
40-
</div>
34+
4135

4236
<!-- Shirt size xs - xxl -->
43-
<div class="form-group">
44-
<label for="Size">T Shirt Size</label>
45-
<select id="Size" name="Size">
37+
38+
<label for="size">T Shirt Size</label>
39+
<select id="size" name="Size">
4640
<option value="XS">XSmall</option>
4741
<option value="S">Small</option>
4842
<option value="M">Medium</option>
@@ -53,9 +47,9 @@ <h1>T Shirt Order Form</h1>
5347
</div>
5448
</form>
5549
</main>
56-
<footer class="footer">
50+
<div class="footer">
5751
<!-- change to your name-->
5852
<p>By John Robinson</p>
59-
</footer>
53+
</div>
6054
</body>
61-
</html>
55+
</html>

0 commit comments

Comments
 (0)