Skip to content

Commit 5e42f93

Browse files
Making some improvement after reading some review comment. Fix some error and update the code for better reading
1 parent ee353eb commit 5e42f93

2 files changed

Lines changed: 6 additions & 10 deletions

File tree

Form-Controls/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@
1414

1515
We are selling t-shirts. Write a form to collect the following data:
1616

17-
Our customers already have accounts, so we know their addresses and charging details already. We don't need to collect that data. We want to confirm they are the right person, then get them to choose a colour and size.
17+
Our customers already have accounts, so we know their addresses and charging details already. We don't need to collect that data. We want to confirm they are the right person, then get them to choose a color and size.
1818

1919
Writing that out as a series of questions to ask yourself:
2020

2121
1. What is the customer's name? I must collect this data, and validate it. But what is a valid name? I must decide something.
2222
2. What is the customer's email? I must make sure the email is valid. Email addresses have a consistent pattern.
23-
3. What colour should this t-shirt be? I must give 3 options. How will I make sure they don't pick other colours?
23+
3. What color should this t-shirt be? I must give 3 options. How will I make sure they don't pick other colors?
2424
4. What size does the customer want? I must give the following 6 options: XS, S, M, L, XL, XXL
2525

2626
All fields are required.
@@ -40,7 +40,7 @@ Let's write out our testable criteria. Check each one off as you complete it.
4040
- [x] My Lighthouse Accessibility score is 100.
4141
- [x] I require a valid name. I have defined a valid name as a text string of two characters or more.
4242
- [x] I require a valid email.
43-
- [x] I require one colour from a defined set of 3 colours.
43+
- [x] I require one color from a defined set of 3 colors.
4444
- [x] I require one size from a defined set of 6 sizes.
4545

4646
## Resources

Form-Controls/index.html

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@ <h1>Product Pick</h1>
1313
</header>
1414
<main>
1515
<form>
16-
<!-- write your html here-->
17-
<!--
18-
try writing out the requirements first as comments
19-
this will also help you fill in your PR message later-->
2016
<div>
2117
<label for="Name">Customer name:</label>
2218
<input type="text" id="Name" name="Name" required placeholder="John Smith">
@@ -29,11 +25,11 @@ <h1>Product Pick</h1>
2925
<br>
3026
<div>
3127
<label for="Color">T-shirt color:</label>
32-
<input type="color" id="Color" name=" Product color" required>
28+
<input type="color" id="Color" name=" Product-Color" required>
3329
</div>
3430
<div>
3531
<br>
36-
<label for="Size">Shirt size
32+
<label for="Size">Shirt size</label>
3733
<select id="Size" name="Shirt size" required>
3834
<option label="XS" value="XS"></option>
3935
<option label="S" value="S"></option>
@@ -51,7 +47,7 @@ <h1>Product Pick</h1>
5147
<hr>
5248
<footer>
5349
<!-- change to your name-->
54-
<h2>By Tuan Nguyen</h2>
50+
<h1>By Tuan Nguyen</h1>
5551
</footer>
5652
</body>
5753
</html>

0 commit comments

Comments
 (0)