Skip to content

Commit 61ea410

Browse files
author
JorvanW
committed
Added lable names for each imput field
1 parent f5922f6 commit 61ea410

2 files changed

Lines changed: 13 additions & 12 deletions

File tree

Form-Controls/README.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
- [x] Interpret requirements and check against a list of criteria
88
- [x] Write a valid form
99
- [x] Test with Devtools
10-
- [ ] Refactor using Devtools
10+
- [x] Refactor using Devtools
1111
- [x] Use version control by committing often and pushing regularly to GitHub
1212
- [x] Develop the habit of writing clean, well-structured, and error-free code
1313
<!--{{<objectives>}}>-->
@@ -39,13 +39,13 @@ Let's write out our testable criteria. Check each one off as you complete it.
3939

4040
### HTML
4141

42-
- [ ] My form is semantic HTML.
43-
- [ ] All inputs have associated labels.
44-
- [ ] My Lighthouse Accessibility score is 100.
45-
- [ ] I require a valid name.
46-
- [ ] I require a valid email.
47-
- [ ] I require one colour from a defined set of 3 colours.
48-
- [ ] I require one size from a defined set of 6 sizes.
42+
- [x] My form is semantic HTML.
43+
- [x] All inputs have associated labels.
44+
- [x] My Lighthouse Accessibility score is 100.
45+
- [x] I require a valid name.
46+
- [x] I require a valid email.
47+
- [x] I require one colour from a defined set of 3 colours.
48+
- [x] I require one size from a defined set of 6 sizes.
4949

5050
### Developers must adhere to professional standards.
5151

Form-Controls/index.html

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333

3434
#submit {
3535
width: 150px;
36+
3637
}
3738
</style>
3839
<body>
@@ -45,8 +46,8 @@ <h1>T-Shirts</h1>
4546
<input id="name" type="text"/>
4647
<label for="email">Email</label>
4748
<input id="email" type="email"/>
48-
<label>Size
49-
<select>
49+
<label for="size">Size
50+
<select id="size">
5051
<option value="xsmall">XS</option>
5152
<option value="small">S</option>
5253
<option value="medium">M</option>
@@ -55,8 +56,8 @@ <h1>T-Shirts</h1>
5556
<option value="xxlarge">XXL</option>
5657
</select>
5758
</label>
58-
<label>Colour
59-
<select>
59+
<label for="colour">Colour
60+
<select id="colour">
6061
<option value="yellow">Yellow</option>
6162
<option value="black">Black</option>
6263
<option value="pink">Pink</option>

0 commit comments

Comments
 (0)