Skip to content

Commit 6e88155

Browse files
committed
Address review feedback and improve CSS structure
1 parent 3940bb8 commit 6e88155

8 files changed

Lines changed: 31 additions & 39 deletions
-14.8 KB
Binary file not shown.
-40.5 KB
Binary file not shown.

Wireframe/git-branch-images.png

14.8 KB
Loading

Wireframe/index.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,23 +13,23 @@ <h1>Web Development Concepts</h1>
1313
</header>
1414
<main>
1515
<article>
16-
<img src="image_thumb10.png" alt="README file example">
16+
<img src="readme-images.png" alt="README file example">
1717
<h2>README.md File</h2>
1818
<p>
1919
A README file explains what a project does, how to install it, and how to use it. It helps other developers understand the project quickly. </p>
2020
<a href="https://www.freecodecamp.org/news/how-to-write-a-good-readme-file/" target="_blank">Read more</a>
2121
</article>
2222

2323
<article>
24-
<img src="02-newspaper-site-wireframe-example.webp" alt="Wireframe example">
24+
<img src="wireframe-images.png" alt="Wireframe example">
2525
<h2>Wireframe</h2>
2626
<p>
2727
A wireframe is a simple visual plan of a webpage. It shows the layout and structure before the website is built.
2828
</p>
2929
<a href="https://www.productplan.com/glossary/wireframe/" target="_blank">Read more</a>
3030
</article>
3131
<article>
32-
<img src="GIT-Branchand-its-Operations.webp" alt="Git branch workflow">
32+
<img src="Git-branch-images.png" alt="Git branch workflow">
3333
<h2>Git Branch</h2>
3434
<p>
3535
A Git branch allows developers to work on new features without changing the main version of a project. Changes can be merged later when they are ready.

Wireframe/style.css

Lines changed: 28 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,11 @@ As well as useful links to learn more */
2727
/* ====== Base Elements ======
2828
General rules for basic HTML elements in any context */
2929
body {
30-
background: var(--paper);
30+
background-color: #d6d0d0;
3131
color: var(--ink);
3232
font: var(--font);
3333
}
34-
a {
35-
padding: var(--space);
36-
border: var(--line);
37-
max-width: fit-content;
38-
}
34+
3935
img,
4036
svg {
4137
width: 100%;
@@ -45,10 +41,7 @@ svg {
4541
Setting the overall rules for page regions
4642
https://www.w3.org/WAI/tutorials/page-structure/regions/
4743
*/
48-
main {
49-
max-width: var(--container);
50-
margin: 0 auto;
51-
}
44+
5245
footer {
5346

5447
text-align: center;
@@ -61,6 +54,8 @@ https://developer.chrome.com/docs/devtools/css/grid
6154
https://gridbyexample.com/learn/
6255
*/
6356
main {
57+
max-width: var(--container);
58+
margin: 0 auto;
6459
display: grid;
6560
grid-template-columns: 1fr 1fr;
6661
gap: var(--space);
@@ -86,8 +81,11 @@ article {
8681
grid-column: span 3;
8782
}
8883
}
84+
85+
/* ====== Custom Styling ====== */
86+
8987
h1 {
90-
color: rgb(47, 159, 174);
88+
color: #006d77;
9189
text-align: center;
9290

9391
}
@@ -100,34 +98,28 @@ header {
10098
}
10199
a {
102100
background-color: black;
103-
color: white;
104-
text-decoration: none;
105-
border-radius: 8px;
106-
transition: 0.3s;
101+
color: white;
102+
text-decoration: none;
103+
border-radius: 8px;
104+
transition: 0.3s;
105+
padding: 8px 16px;
106+
width: 100px;
107+
height: 20px;
108+
line-height: 20px;
109+
text-align: center;
110+
display: inline-block;
111+
max-width: fit-content;
107112
}
108-
a:hover{
113+
a:hover {
109114
background-color: teal;}
110115

111-
112-
article {
113-
border: var(-- line);
114-
padding-bottom: var(--space);
115-
text-align: left;
116-
display: grid;
117-
grid-template-columns: var(--space) 1fr var(--space);
118-
border-radius: 12px;
119-
overflow: hidden;
120-
padding: 16px;
116+
article:hover {
117+
transform: scale(1.02);
121118
}
122119

123-
article:hover { transform: scale(1.02);}
124-
125-
body { background-color: #d6d0d0;}
126-
127-
h1 { color: rgb(47, 120, 120); }
128-
129-
p { color: #333333; }
130-
a { background-color: black;
131-
color: white;
132-
120+
p {
121+
color: #333333;
122+
}
123+
article:last-child a {
124+
margin-top: 30px;
133125
}

Wireframe/wireframe-images.png

7.18 KB
Loading

Wireframe/wireframe.png

-55.4 KB
Binary file not shown.

0 commit comments

Comments
 (0)