Skip to content

Commit 790019b

Browse files
fixing the closing '<code></select></code>' tag at line 65 and changing arial-describedby to aria-describedby in the fistname, last name and email, password input element
1 parent 7b3e78e commit 790019b

1 file changed

Lines changed: 23 additions & 20 deletions

File tree

Form-Controls/index.html

Lines changed: 23 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -14,45 +14,45 @@ <h1>Product Pick</h1>
1414
<main>
1515
<form>
1616
<!-- First name-->
17-
<section class="form-group">
17+
<fieldset>
1818
<label for = "first-name">First Name</label>
1919
<input type="text" id="first-name" name="first-name" required pattern=".*\S.*\S.*"
20-
arial-describedby="fnameHelp"</>
20+
aria-describedby="fnameHelp"</>
2121
<small id="fnameHelp">Must be at least 2 characters long</small>
22-
</section>
22+
</fieldset>
2323
<!-- Last name-->
24-
<section class="form-group">
24+
<fieldset>
2525
<label for = "last-name">Last Name</label>
2626
<input type="text" id="last-name" name="last-name" required pattern=".*\S.*\S.*"
27-
arial-describedby="lnameHelp"</>
27+
aria-describedby="lnameHelp"</>
2828
<small id="lnameHelp">Must be at least 2 characters long</small>
29-
</section>
29+
</fieldset>
3030
<!-- Email-->
31-
<section class="form-group">
31+
<fieldset>
3232
<label for = "email">Email</label>
3333
<input type="email" id="email" name="email" required pattern="[a-z0-9._%+-]+@[a-z0-9.-]+\.[a-z]{2,}$"
34-
arial-describedby="emailHelp"</>
34+
aria-describedby="emailHelp"</>
3535
<small id="emailHelp">Must be a valid email address</small>
36-
</section>
36+
</fieldset>
3737
<!-- Password-->
38-
<section class="form-group">
38+
<fieldset>
3939
<label for = "password">Password</label>
4040
<input type="password" id="password" name="password" required pattern="^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[@$!%*?&])[A-Za-z\d@$!%*?&]{8,}$"
41-
arial-describedby="passwordHelp"</>
41+
aria-describedby="passwordHelp"</>
4242
<small id="passwordHelp">Must be at least 8 characters long and include at least one uppercase letter, one lowercase letter, one number, and one special character</small>
43-
</section>
43+
</fieldset>
4444
<!--Shirt Color-->
45-
<section class="form-group">
45+
<fieldset>
4646
<label for = "shirt-color">Shirt Color</label>
4747
<select id="shirt-color" name="shirt-color" required>
4848
<option value="">Select a color</option>
4949
<option value="red">Red</option>
5050
<option value="blue">Blue</option>
5151
<option value="green">Green</option>
5252
</select>
53-
</section>
53+
</fieldset>
5454
<!---Shirt Size-->
55-
<section class="form-group">
55+
<fieldset>
5656
<label for = "shirt-size">Shirt Size</label>
5757
<select id="shirt-size" name="shirt-size" required>
5858
<option value="">Select a size</option>
@@ -62,12 +62,15 @@ <h1>Product Pick</h1>
6262
<option value="L">L</option>
6363
<option value="XL">XL</option>
6464
<option value="XXL">XXL</option>
65-
</select>
66-
</section>
65+
</select>
66+
</fieldset>
67+
6768
<!--Submit button-->
68-
<section class="form-group">
69-
<button type="submit">Submit</button>
70-
</section>
69+
<fieldset>
70+
<label for = "submit"></label>
71+
<select id="submit" name="submit">
72+
<button type="submit">Submit Form </button>
73+
</fieldset>
7174

7275
<!--
7376
What is the customer's name? I must collect this data and ensure it contains at least two non-space characters.

0 commit comments

Comments
 (0)