Skip to content

Commit 7a88528

Browse files
committed
CSS chages
-removed the instruction -updated a styling the border colour -added h1, h2 and p style -removed fixed position of the footer
1 parent ad8d59f commit 7a88528

1 file changed

Lines changed: 15 additions & 19 deletions

File tree

Wireframe/style.css

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,11 @@
1-
/* Here are some starter styles
2-
You can edit these or replace them entirely
3-
It's showing you a common way to organise CSS
4-
And includes solutions to common problems
5-
As well as useful links to learn more */
61

7-
/* ====== Design Palette ======
8-
This is our "design palette".
9-
It sets out the colours, fonts, styles etc to be used in this design
10-
At work, a designer will give these to you based on the corporate brand, but while you are learning
11-
You can design it yourself if you like
12-
Inspect the starter design with Devtools
13-
Click on the colour swatches to see what is happening
14-
I've put some useful CSS you won't have learned yet
15-
For you to explore and play with if you are interested
16-
https://web.dev/articles/min-max-clamp
17-
https://scrimba.com/learn-css-variables-c026
18-
====== Design Palette ====== */
2+
/*====== Design Palette ====== */
193
:root {
204
--paper: oklch(7 0 0);
215
--ink: color-mix(in oklab, var(--color) 5%, black);
226
--font: 100%/1.5 system-ui;
237
--space: clamp(6px, 6px + 2vw, 15px);
24-
--line: 1px solid;
8+
--line: 1px solid rgb(201, 198, 198);
259
--container: 1280px;
2610
}
2711
/* ====== Base Elements ======
@@ -31,10 +15,20 @@ body {
3115
color: var(--ink);
3216
font: var(--font);
3317
}
18+
h1{
19+
text-align: center;
20+
padding: var(--space);
21+
}
22+
h2, p{
23+
padding: var(--space);
24+
margin: var(--space);
25+
}
3426
a {
3527
padding: var(--space);
28+
margin: var(--space);
3629
border: var(--line);
3730
max-width: fit-content;
31+
border-radius: 5px;
3832
}
3933
img,
4034
svg {
@@ -50,7 +44,8 @@ main {
5044
margin: 0 auto calc(var(--space) * 4) auto;
5145
}
5246
footer {
53-
position: fixed;
47+
padding: var(--space);
48+
margin: var(--space);
5449
bottom: 0;
5550
text-align: center;
5651
}
@@ -76,6 +71,7 @@ Keeping things orderly and separate is the key to good, simple CSS.
7671
*/
7772
article {
7873
border: var(--line);
74+
border-radius: 5px;
7975
padding-bottom: var(--space);
8076
text-align: left;
8177
display: grid;

0 commit comments

Comments
 (0)