Skip to content

Commit 821470b

Browse files
committed
update css
1 parent cc640aa commit 821470b

1 file changed

Lines changed: 12 additions & 36 deletions

File tree

Wireframe/style.css

Lines changed: 12 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,4 @@
1-
/* Here are some starter styles
2-
You can edit these or replace them entirely
3-
It's showing you a common way to organise CSS
4-
And includes solutions to common problems
5-
As well as useful links to learn more */
6-
7-
/* ====== Design Palette ======
8-
This is our "design palette".
9-
It sets out the colours, fonts, styles etc to be used in this design
10-
At work, a designer will give these to you based on the corporate brand, but while you are learning
11-
You can design it yourself if you like
12-
Inspect the starter design with Devtools
13-
Click on the colour swatches to see what is happening
14-
I've put some useful CSS you won't have learned yet
15-
For you to explore and play with if you are interested
16-
https://web.dev/articles/min-max-clamp
17-
https://scrimba.com/learn-css-variables-c026
18-
====== Design Palette ====== */
1+
/* ====== Design Palette ====== */
192
html {
203
font-size: 18px;
214
line-height: 1.2;
@@ -32,8 +15,7 @@ html {
3215
--line: 1px solid #F5F5F5;
3316
--container: 1280px;
3417
}
35-
/* ====== Base Elements ======
36-
General rules for basic HTML elements in any context */
18+
/* ====== Base Elements ====== */
3719
body {
3820
display: grid;
3921
grid-template-rows: auto 1fr auto;
@@ -52,10 +34,7 @@ svg {
5234
width: 100%;
5335
object-fit: cover;
5436
}
55-
/* ====== Site Layout ======
56-
Setting the overall rules for page regions
57-
https://www.w3.org/WAI/tutorials/page-structure/regions/
58-
*/
37+
/* ====== Site Layout ====== */
5938

6039
header {
6140
text-align: center;
@@ -68,14 +47,15 @@ footer {
6847
/* position: fixed; */
6948
bottom: 0;
7049
text-align: center;
50+
left: 50%;
51+
transform: translateX(-50%);
52+
width: 100%;
53+
text-align: center;
54+
background-color: #f1f1f1;
55+
padding: 10px 0;
56+
box-shadow: 0 -1px 5px rgba(0,0,0,0.1);
7157
}
72-
/* ====== Articles Grid Layout ====
73-
Setting the rules for how articles are placed in the main element.
74-
Inspect this in Devtools and click the "grid" button in the Elements view
75-
Play with the options that come up.
76-
https://developer.chrome.com/docs/devtools/css/grid
77-
https://gridbyexample.com/learn/
78-
*/
58+
/* ====== Articles Grid Layout ==== */
7959

8060

8161
@media (min-width: 550px) {
@@ -88,11 +68,7 @@ https://gridbyexample.com/learn/
8868
}
8969
}
9070
}
91-
/* ====== Article Layout ======
92-
Setting the rules for how elements are placed in the article.
93-
Now laying out just the INSIDE of the repeated card/article design.
94-
Keeping things orderly and separate is the key to good, simple CSS.
95-
*/
71+
/* ====== Article Layout ====== */
9672
article {
9773
border: var(--line);
9874
padding-bottom: var(--space);

0 commit comments

Comments
 (0)