Skip to content

Commit 83bc6f9

Browse files
YoditEYoditE
committed
Fix review comments and update images
1 parent 4438783 commit 83bc6f9

5 files changed

Lines changed: 9 additions & 11 deletions

File tree

‎Wireframe/02-newspaper-site-wireframe-example.webp‎

14.8 KB
Loading

‎Wireframe/GIT-Branchand-its-Operations.webp‎

40.5 KB
Loading

‎Wireframe/image_thumb10.png‎

16.2 KB
Loading

‎Wireframe/index.html‎

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,33 +8,31 @@
88
</head>
99
<body>
1010
<header>
11-
<h1><h1>Web Development Concepts</h1></h1>
12-
<p>
11+
<h1>Web Development Concepts</h1>
1312
<p>Learn about README files, wireframes, and Git branches.</p>
14-
</p>
1513
</header>
1614
<main>
1715
<article>
18-
<img src="https://saraford.net/wp-content/uploads/2017/02/image_thumb10.png?w=593&h=408" alt="" />
16+
<img src="image_thumb10.png" alt="README file example">
1917
<h2>README.md File</h2>
2018
<p>
2119
A README file explains what a project does, how to install it, and how to use it. It helps other developers understand the project quickly. </p>
22-
<a href="">Read more</a>
20+
<a href="https://www.freecodecamp.org/news/how-to-write-a-good-readme-file/" target="_blank">Read more</a>
2321
</article><article>
24-
<img src="https://cdn-images.visual-paradigm.com/handbooks/agile-handbook/wireframe/02-newspaper-site-wireframe-example.png" alt="" />
22+
<img src="02-newspaper-site-wireframe-example.webp" alt="Wireframe example">
2523
<h2>Wireframe</h2>
2624
<p>
2725
A wireframe is a simple visual plan of a webpage. It shows the layout and structure before the website is built.
2826
</p>
29-
<a href="">Read more</a>
27+
<a href="https://www.productplan.com/glossary/wireframe/" target="_blank">Read more</a>
3028
</article>
3129
<article>
32-
<img src="https://media2.dev.to/dynamic/image/width=1000,height=420,fit=cover,gravity=auto,format=auto/https%3A%2F%2Fdev-to-uploads.s3.amazonaws.com%2Fuploads%2Farticles%2Fx9kl8nf8ir54f5pgrrop.png" alt="" />
30+
<img src="GIT-Branchand-its-Operations.webp" alt="Git branch workflow">
3331
<h2>Git Branch</h2>
3432
<p>
3533
A Git branch allows developers to work on new features without changing the main version of a project. Changes can be merged later when they are ready.
3634
</p>
37-
<a href="">Read more</a>
35+
<a href="https://www.w3schools.com/git/git_branch.asp" target="_blank">Read more</a>
3836
</article>
3937

4038
</main>
@@ -44,4 +42,3 @@ <h2>Git Branch</h2>
4442
</p>
4543
</footer>
4644
</body>
47-
</html>

‎Wireframe/style.css‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ https://www.w3.org/WAI/tutorials/page-structure/regions/
4747
*/
4848
main {
4949
max-width: var(--container);
50-
margin: 0 auto calc(var(--space) * 4) auto;
50+
margin: 0 auto;
51+
margin-bottom: calc(var(--space) * 4);
5152
}
5253
footer {
5354

0 commit comments

Comments
 (0)