Skip to content

Commit ceb09d7

Browse files
committed
update link styling, footer content and article links
- remove footer positioning - update footer placeholder text - simplify footer link styling - add article links, and adjust their styling
1 parent 0a4362f commit ceb09d7

2 files changed

Lines changed: 16 additions & 6 deletions

File tree

Wireframe/index.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ <h2>What is a README file?</h2>
2222
<p>
2323
A README is ...
2424
</p>
25-
<a href="">Read more</a>
25+
<a href="https://www.makeareadme.com/" target="_blank">Read more</a>
2626
</article>
2727

2828
<article>
@@ -31,7 +31,7 @@ <h2>What is the purpose of a wireframe?</h2>
3131
<p>
3232
A wireframe is ...
3333
</p>
34-
<a href="">Read more</a>
34+
<a href="https://balsamiq.com/blog/what-are-wireframes/" target="_blank">Read more</a>
3535
</article>
3636

3737
<article>
@@ -40,13 +40,13 @@ <h2>What is a branch in Git?</h2>
4040
<p>
4141
A branch in Git is ...
4242
</p>
43-
<a href="">Read more</a>
43+
<a href="https://www.geeksforgeeks.org/git/introduction-to-git-branch/" target="_blank">Read more</a>
4444
</article>
4545

4646
</main>
4747
<footer>
4848
<p>
49-
2026 Developer Essentials · <a href="https://curriculum.codeyourfuture.io/itp/">Code Your Future — Intro to Programming</a>
49+
This page was built following a provided wireframe design:<a href="https://github.com/edinakurdi/Module-Onboarding/blob/main/Wireframe/README.md">Wireframe</a>
5050
</p>
5151
</footer>
5252
</body>

Wireframe/style.css

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ As well as useful links to learn more */
1919
:root {
2020
--paper: oklch(7 0 0);
2121
--ink: color-mix(in oklab, var(--color) 5%, black);
22-
--font: 100%/1.5 system-ui;
22+
/* increased font size, since it felt tiny */
23+
--font: 1.15rem/1.5 system-ui;
2324
--space: clamp(6px, 6px + 2vw, 15px);
2425
--line: 1px solid;
2526
--container: 1280px;
@@ -35,6 +36,8 @@ a {
3536
padding: var(--space);
3637
border: var(--line);
3738
max-width: fit-content;
39+
padding: 4px 20px;
40+
text-decoration: none;
3841
}
3942
img,
4043
svg {
@@ -45,15 +48,22 @@ svg {
4548
Setting the overall rules for page regions
4649
https://www.w3.org/WAI/tutorials/page-structure/regions/
4750
*/
51+
header {
52+
text-align: center;
53+
}
4854
main {
4955
max-width: var(--container);
5056
margin: 0 auto calc(var(--space) * 4) auto;
57+
padding: 0 8rem;
5158
}
5259
footer {
53-
position: fixed;
5460
bottom: 0;
5561
text-align: center;
5662
}
63+
footer a {
64+
padding: 5px ;
65+
border: none
66+
}
5767
/* ====== Articles Grid Layout ====
5868
Setting the rules for how articles are placed in the main element.
5969
Inspect this in Devtools and click the "grid" button in the Elements view

0 commit comments

Comments
 (0)