Skip to content

Commit f8f7b15

Browse files
committed
Fixed the issues by following the recommendation
replace the <br> with css margin correct the space in the href fixed the footer so that it can be displayed at the bottom of the page
1 parent 94bd6ab commit f8f7b15

2 files changed

Lines changed: 29 additions & 13 deletions

File tree

Wireframe/index.html

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@
1111
<body>
1212

1313
<header>
14-
<h1 style="text-align: center">Webpage Explanation for Key Concept Questions</h1>
14+
<h1>Webpage Explanation for Key Concept Questions</h1>
1515
<nav>
16-
<ul style="justify-content: center; display: flex; gap: var(--space);">
17-
<li><a href=" #readme">What is the purpose of a README file?</a></li>
16+
<ul>
17+
<li><a href="#readme">What is the purpose of a README file?</a></li>
1818
<li><a href="#wireframe">What is the purpose of a wireframe?</a></li>
1919
<li><a href="#git-branch">What is a branch in Git?</a></li>
2020
</ul>
@@ -38,21 +38,20 @@ <h2>What is the purpose of a README file?</h2>
3838
<article id="wireframe">
3939
<img src="wireframe.svg" alt="Illustration of a website user interface wireframe" />
4040
<h2>What is the purpose of a wireframe?</h2>
41-
<p>
42-
Wireframes are the foundational blueprints of a website or app. Used early in the development process,
41+
<p>Wireframes are the foundational blueprints of a website or app. Used early in the development process,
4342
they help teams visualize structure, map user flows, and establish content hierarchy before committing to costly
4443
colors, branding, or final UI design.
4544
</p>
46-
<a class="hyperlink" href="https://www.productplan.com/glossary/wireframeFilter/" target="_blank"
47-
rel="noopener">Read more</a>
45+
<a class="hyperlink" href="https://en.wikipedia.org/wiki/Website_wireframe" target="_blank" rel="noopener">Read
46+
more</a>
4847
</article>
4948

5049
<article id="git-branch">
5150
<img src="branch.svg" alt="Diagram showing Git branches diverging from a main commit history" />
5251
<h2>What is a branch in Git?</h2>
53-
<p>
54-
A branch in Git is simply a lightweight movable pointer to one of these commits. The default branch name
55-
in Git is typically master or main.<br><br></br>
52+
<p id="branch">A branch in Git is simply a lightweight movable pointer to one of these commits. The default branch
53+
name
54+
in Git is typically master or main.
5655
</p>
5756
<a class="hyperlink" href="https://www.w3schools.com/GIT/git_branch.asp?remote=github" target="_blank"
5857
rel="noopener">Read more</a>

Wireframe/style.css

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@ As well as useful links to learn more */
1515
For you to explore and play with if you are interested
1616
https://web.dev/articles/min-max-clamp
1717
https://scrimba.com/learn-css-variables-c026
18-
====== Design Palette ====== */
18+
19+
20+
====== Design Palette ====== */
1921
:root {
2022
--paper: oklch(7 0 0);
2123
--ink: color-mix(in oklab, var(--color) 5%, black);
@@ -50,9 +52,14 @@ Setting the overall rules for page regions
5052
https://www.w3.org/WAI/tutorials/page-structure/regions/
5153
*/
5254
footer {
53-
position: relative;
55+
position: fixed;
5456
bottom: 0;
5557
text-align: center;
58+
margin-bottom: calc(var(--space) * 2);
59+
}
60+
61+
#branch {
62+
margin-bottom: calc(var(--space) * 4);
5663
}
5764

5865
/* ====== Articles Grid Layout ====
@@ -79,12 +86,23 @@ Setting the rules for how elements are placed in the article.
7986
Now laying out just the INSIDE of the repeated card/article design.
8087
Keeping things orderly and separate is the key to good, simple CSS.
8188
*/
89+
h1 {
90+
text-align: center;
91+
}
92+
93+
ul {
94+
justify-content: center;
95+
display: flex;
96+
gap: var(--space)
97+
}
98+
8299
article {
83100
border: var(--line);
84101
padding-bottom: var(--space);
85102
text-align: left;
86103
display: grid;
87104
grid-template-columns: var(--space) 1fr var(--space);
105+
margin-bottom: calc(var(--space) * 2);
88106

89107
>* {
90108
grid-column: 2/3;
@@ -105,5 +123,4 @@ article {
105123
max-width: fit-content;
106124
vertical-align: top;
107125
}
108-
109126
}

0 commit comments

Comments
 (0)