Skip to content

Commit ff8f2b9

Browse files
Correction after review
1 parent c955206 commit ff8f2b9

1 file changed

Lines changed: 18 additions & 9 deletions

File tree

Form-Controls/index.html

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,23 @@ <h1>Product Pick</h1>
1414
<main>
1515
<form>
1616
<label for="user-name">Your Name:</label>
17-
<input id="user-name" type="text" pattern="[A-Za-z\s]{2,}" title="Please enter at least 2 letters. Numbers and symbols are not allowed" required>
17+
<input id="user-name" type="text" pattern="[A-Za-z\s\-]{2,}" title="Please enter at least 2 letters. Numbers and symbols are not allowed" required>
1818

1919

2020
<br>
2121

2222
<label for="email">Your Email:</label>
23-
<input id="email" type="email" required>
24-
<button id="go"> Go
23+
<input id="email" name="user_email" type="email" required>
24+
<button id="go" type="submit"> GoWeiTsungCheng19 hours ago
25+
You should put your name here
26+
27+
WeiTsungCheng19 hours ago
28+
This is incorrectly expressed.
29+
30+
Besides some duplicate values, the value of size should not be color.
31+
32+
WeiTsungCheng19 hours ago
33+
It's best to include a name in the input field. Or the form won't include the data when you submit it
2534
</button>
2635

2736
<br>
@@ -40,11 +49,11 @@ <h1>Product Pick</h1>
4049

4150
<select id="shirtsize" name="size" required>
4251
<option value="" disabled selected>Select a size...</option>
43-
<option value="red">S</option>
44-
<option value="blue">M</option>
45-
<option value="green">L</option>
46-
<option value="green">XL</option>
47-
<option value="green">XXL</option>
52+
<option value="s">S</option>
53+
<option value="m">M</option>
54+
<option value="l">L</option>
55+
<option value="xl">XL</option>
56+
<option value="xxl">XXL</option>
4857
</select>
4958
</form>
5059
</main>
@@ -56,7 +65,7 @@ <h1>Product Pick</h1>
5665
</html>
5766
<footer>
5867
<!-- change to your name-->
59-
<p>By HOMEWORK SOLUTION</p>
68+
<p>Chan Yat Long</p>
6069
</footer>
6170
</body>
6271
</html>

0 commit comments

Comments
 (0)