From 75f6ff761b97fdf2eb6831a544c3656aba170040 Mon Sep 17 00:00:00 2001 From: Adam Sutton Date: Fri, 24 Apr 2026 12:39:31 +0100 Subject: [PATCH 1/2] fixing the comp name requirement --- .../src/medcat_embedding_linker/embedding_linker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/medcat-plugins/embedding-linker/src/medcat_embedding_linker/embedding_linker.py b/medcat-plugins/embedding-linker/src/medcat_embedding_linker/embedding_linker.py index a056a4b51..60ac8e6fd 100644 --- a/medcat-plugins/embedding-linker/src/medcat_embedding_linker/embedding_linker.py +++ b/medcat-plugins/embedding-linker/src/medcat_embedding_linker/embedding_linker.py @@ -585,7 +585,7 @@ def _pre_inference( def predict_entities( self, doc: MutableDocument, ents: list[MutableEntity] | None = None ) -> list[MutableEntity]: - if self.cnf_l.train and self.comp_name == "embedding_linker": + if self.cnf_l.train and self.name == "embedding_linker": logger.warning( "Attemping to train a static embedding linker. " "This is not possible / required." From 98450bc6e105e5bba51e1b985ad26930fd90bfb2 Mon Sep 17 00:00:00 2001 From: Adam Sutton Date: Fri, 24 Apr 2026 16:48:48 +0100 Subject: [PATCH 2/2] fixes to testing --- .../embedding-linker/tests/test_embedding_linker.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/medcat-plugins/embedding-linker/tests/test_embedding_linker.py b/medcat-plugins/embedding-linker/tests/test_embedding_linker.py index 06dedc031..1b9591c10 100644 --- a/medcat-plugins/embedding-linker/tests/test_embedding_linker.py +++ b/medcat-plugins/embedding-linker/tests/test_embedding_linker.py @@ -81,9 +81,9 @@ class TrainableEmbeddingLinkerTests(unittest.TestCase): cnf = Config() cnf.components.linking = embedding_linker.EmbeddingLinking() cnf.components.linking.comp_name = ( - trainable_embedding_linker.TrainableEmbeddingLinker.name + trainable_embedding_linker.Linker.name ) - linker = trainable_embedding_linker.TrainableEmbeddingLinker(FakeCDB(cnf), cnf) + linker = trainable_embedding_linker.Linker(FakeCDB(cnf), cnf) def test_linker_is_trainable(self): self.assertIsInstance(self.linker, TrainableComponent)