diff --git a/.jules/sentinel.md b/.jules/sentinel.md index a8207a4..3255af5 100644 --- a/.jules/sentinel.md +++ b/.jules/sentinel.md @@ -2,3 +2,7 @@ **Vulnerability:** Unvalidated inputs passed to `if()` statements can cause process crashes (`condition has length > 1`) or unexpected coercion vulnerabilities. **Learning:** In R, optional boolean parameters that default to `NULL` should be validated using explicit runtime type validation (e.g., `if (!is.null(flag) && (!is.logical(flag) || length(flag) != 1 || is.na(flag)))`). **Prevention:** Always implement explicit runtime type validation for optional boolean parameters. +## 2024-05-24 - [CRITICAL] Prevent Integer Overflow Coercion in Interactive Prompts +**Vulnerability:** Interactive `readline()` prompt validations were using unbounded digit classes (`^[0-9]+$`) to match single-digit numeric inputs (e.g., "1" or "2"). +**Learning:** This approach enables integer overflow coercion vulnerabilities. When an excessively large numeric string is passed, it matches the regex but evaluates to `NA` when coerced via `as.integer()`. This allows unexpected values to bypass the validation and can cause subsequent process crashes (Denial of Service) when passed to downstream logic expecting a valid integer. +**Prevention:** Strictly match against the exact expected values (e.g., `^[12]$`) rather than unbounded digit classes when validating interactive `readline()` numeric inputs. diff --git a/R/aFIPC.R b/R/aFIPC.R index 6254651..918e19b 100644 --- a/R/aFIPC.R +++ b/R/aFIPC.R @@ -141,7 +141,7 @@ autoFIPC <- } for (attempt in seq_len(3)) { n <- readline(prompt = "Is it correct? (1: Yes 2: No) : ") - if (grepl("^[0-9]+$", n)) { + if (grepl("^[12]$", n)) { return(as.integer(n)) } } @@ -171,7 +171,7 @@ autoFIPC <- readline( prompt = "Do you want to use default BILOG-MG priors for oldform Data? (1: Yes 2: No) : " ) - if (grepl("^[0-9]+$", n)) { + if (grepl("^[12]$", n)) { return(as.integer(n)) } } @@ -390,7 +390,7 @@ autoFIPC <- readline( prompt = "Do you want to use default BILOG-MG priors for newform Data? (1: Yes 2: No) : " ) - if (grepl("^[0-9]+$", n)) { + if (grepl("^[12]$", n)) { return(as.integer(n)) } }