From 8afd7fe3ddaadcac15afbd203f5e75c9eb5e1e29 Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Fri, 24 Jul 2026 19:11:41 +0000 Subject: [PATCH 1/4] =?UTF-8?q?=E2=9A=A1=20Bolt:=20R=20=EC=96=B8=EC=96=B4?= =?UTF-8?q?=EC=97=90=EC=84=9C=20=EC=B5=9C=EC=86=8C=EA=B0=92=20=ED=83=90?= =?UTF-8?q?=EC=83=89=EC=9D=84=20=EC=9C=84=ED=95=B4=20=EC=A0=84=EC=B2=B4=20?= =?UTF-8?q?=EB=8D=B0=EC=9D=B4=ED=84=B0=EB=A5=BC=20=EC=A0=95=EB=A0=AC(O(N?= =?UTF-8?q?=20log=20N))=ED=95=98=EB=8A=94=20=EB=B6=80=EB=B6=84=EC=9D=84=20?= =?UTF-8?q?=EB=8B=A8=EC=9D=BC=20=EC=B5=9C=EC=86=8C=EA=B0=92=20=ED=83=90?= =?UTF-8?q?=EC=83=89(which.min,=20O(N))=EC=9C=BC=EB=A1=9C=20=EC=B5=9C?= =?UTF-8?q?=EC=A0=81=ED=99=94?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .jules/bolt.md | 3 +++ R/surveyFA.R | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.jules/bolt.md b/.jules/bolt.md index 7d3c603..455bbad 100644 --- a/.jules/bolt.md +++ b/.jules/bolt.md @@ -16,3 +16,6 @@ ## 2025-02-12 - R 언어에서 반복적인 mirt 모델 생성 시 불필요한 데이터프레임 부분집합 추출 최적화 **Learning:** R에서 데이터프레임의 특정 열을 추출하는 작업(`df[cols]`)은 O(N)의 메모리 복사를 수반합니다. `autoFIPC`에서 `mirt` 모델의 파라미터를 설정하거나 호출하는 과정 중에 `newformXDataK[colnames(newFormModel@Data$data)]` 코드가 반복해서 사용되었고, 심지어 `ncol()`을 위해 단순히 개수를 구할 때도 사용되어 불필요한 메모리 할당과 오버헤드를 초래했습니다. **Action:** 조건문이나 반복문 내부에서 불필요하게 데이터프레임 부분집합 연산이 반복되지 않도록 외부에서 한 번만 `linkedFormData <- newformXDataK[colnames(newFormModel@Data$data)]`로 캐싱(caching)한 뒤, `ncol(linkedFormData)`와 `data = linkedFormData` 형태로 재사용하여 메모리 복사와 O(N) 오버헤드를 방지해야 합니다. +## 2025-02-13 - R 언어에서 정렬 기반 최소/최대값 탐색(sort) 최적화 +**Learning:** R에서 최솟값 또는 최댓값을 찾기 위해 `sort(x)[1]`이나 `names(sort(x))[1]`을 사용하면 전체 배열을 정렬해야 하므로 O(N log N)의 오버헤드가 발생합니다. +**Action:** `sort()` 대신 `which.min(x)` 또는 `which.max(x)`를 사용하여 O(N) 선형 시간 복잡도로 성능을 최적화해야 합니다. (예: `names(sort(x))[1]` 대신 `names(which.min(x))`) diff --git a/R/surveyFA.R b/R/surveyFA.R index f60fffd..c24ec62 100644 --- a/R/surveyFA.R +++ b/R/surveyFA.R @@ -232,7 +232,8 @@ surveyFA <- function( names(p_values) <- rownames(fit_df) if (any(!is.na(p_values))) { p_values[is.na(p_values)] <- 1 - candidate <- names(sort(p_values, decreasing = FALSE))[1L] + # ⚡ Bolt: Replace O(N log N) sort() with O(N) which.min() + candidate <- names(p_values)[which.min(p_values)] if (!is.na(candidate) && p_values[[candidate]] < pThreshold) { return(candidate) } From 7b7a92147fdefdeed87c6c5842096c7611682a4a Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Fri, 24 Jul 2026 19:22:54 +0000 Subject: [PATCH 2/4] =?UTF-8?q?=E2=9A=A1=20Bolt:=20R=20=EC=96=B8=EC=96=B4?= =?UTF-8?q?=EC=97=90=EC=84=9C=20=EC=B5=9C=EC=86=8C=EA=B0=92=20=ED=83=90?= =?UTF-8?q?=EC=83=89=EC=9D=84=20=EC=9C=84=ED=95=B4=20=EC=A0=84=EC=B2=B4=20?= =?UTF-8?q?=EB=8D=B0=EC=9D=B4=ED=84=B0=EB=A5=BC=20=EC=A0=95=EB=A0=AC(O(N?= =?UTF-8?q?=20log=20N))=ED=95=98=EB=8A=94=20=EB=B6=80=EB=B6=84=EC=9D=84=20?= =?UTF-8?q?=EB=8B=A8=EC=9D=BC=20=EC=B5=9C=EC=86=8C=EA=B0=92=20=ED=83=90?= =?UTF-8?q?=EC=83=89(which.min,=20O(N))=EC=9C=BC=EB=A1=9C=20=EC=B5=9C?= =?UTF-8?q?=EC=A0=81=ED=99=94?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix `R CMD check` NOTE about hidden `.semgrepignore` file by adding it to `.Rbuildignore` --- .Rbuildignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.Rbuildignore b/.Rbuildignore index 232504f..388f1c6 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -22,3 +22,4 @@ ^\.jules(/.*)?$ ^\.trivyignore\.yaml$ ^trivy\.yaml$ +^\.semgrepignore$ From a010d925a17eba42b732cf2cdd68a2122b91ed4a Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Fri, 24 Jul 2026 19:29:38 +0000 Subject: [PATCH 3/4] =?UTF-8?q?=E2=9A=A1=20Bolt:=20R=20=EC=96=B8=EC=96=B4?= =?UTF-8?q?=EC=97=90=EC=84=9C=20=EC=B5=9C=EC=86=8C=EA=B0=92=20=ED=83=90?= =?UTF-8?q?=EC=83=89=EC=9D=84=20=EC=9C=84=ED=95=B4=20=EC=A0=84=EC=B2=B4=20?= =?UTF-8?q?=EB=8D=B0=EC=9D=B4=ED=84=B0=EB=A5=BC=20=EC=A0=95=EB=A0=AC(O(N?= =?UTF-8?q?=20log=20N))=ED=95=98=EB=8A=94=20=EB=B6=80=EB=B6=84=EC=9D=84=20?= =?UTF-8?q?=EB=8B=A8=EC=9D=BC=20=EC=B5=9C=EC=86=8C=EA=B0=92=20=ED=83=90?= =?UTF-8?q?=EC=83=89(which.min,=20O(N))=EC=9C=BC=EB=A1=9C=20=EC=B5=9C?= =?UTF-8?q?=EC=A0=81=ED=99=94?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix `R CMD check` NOTE about hidden `.semgrepignore` file by adding it to `.Rbuildignore` From 7f045e382af9496cb57bac6e3c58d98484eb53d1 Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Fri, 24 Jul 2026 19:54:15 +0000 Subject: [PATCH 4/4] =?UTF-8?q?=E2=9A=A1=20Bolt:=20R=20=EC=96=B8=EC=96=B4?= =?UTF-8?q?=EC=97=90=EC=84=9C=20=EC=B5=9C=EC=86=8C=EA=B0=92=20=ED=83=90?= =?UTF-8?q?=EC=83=89=EC=9D=84=20=EC=9C=84=ED=95=B4=20=EC=A0=84=EC=B2=B4=20?= =?UTF-8?q?=EB=8D=B0=EC=9D=B4=ED=84=B0=EB=A5=BC=20=EC=A0=95=EB=A0=AC(O(N?= =?UTF-8?q?=20log=20N))=ED=95=98=EB=8A=94=20=EB=B6=80=EB=B6=84=EC=9D=84=20?= =?UTF-8?q?=EB=8B=A8=EC=9D=BC=20=EC=B5=9C=EC=86=8C=EA=B0=92=20=ED=83=90?= =?UTF-8?q?=EC=83=89(which.min,=20O(N))=EC=9C=BC=EB=A1=9C=20=EC=B5=9C?= =?UTF-8?q?=EC=A0=81=ED=99=94?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix `R CMD check` WARNING about hidden `.Rcheck` directory by adding it to `.Rbuildignore` - Fix `R CMD check` NOTE about hidden `.semgrepignore` file by adding it to `.Rbuildignore` --- .Rbuildignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.Rbuildignore b/.Rbuildignore index 388f1c6..bfcbd1f 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -23,3 +23,5 @@ ^\.trivyignore\.yaml$ ^trivy\.yaml$ ^\.semgrepignore$ +^\.\.Rcheck$ +^\.\.Rcheck/.*