-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomers
Description
Type of Change
- New Feature Request
- Documentation
- Improvement / Suggestion
- Bug
- Other (please clarify below)
Summary
Currently when there is an error returning the Promise in both scripts, the current logic doesn't actually log the error, instead it inadvertently passed a function back.
() => {
console.error(err); // eslint-disable-line no-console
}Details
The reject should just return the error back instead
}).on('error', (err) => {
reject(err);
});Also, all run blocks should make sure they catch the error, e.g.
function run() {
getTopology()
.then(handleIngestionResponse)
.catch((error) => {
console.error(error); // eslint-disable-line no-console
});
}Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomers