fix(snapshot): hash storage ids for file paths#315
Open
OnlyYu1996 wants to merge 1 commit into
Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PlatformNetwork/bounty-challenge#53119.
Snapshot IDs and session IDs were previously interpolated directly into
snapshot_metafilenames. Path components in those IDs could therefore influence the filesystem path used by snapshot and revert-history reads/writes.This PR stores snapshots and revert histories under deterministic SHA-256-derived filenames instead of raw IDs, while still allowing safe legacy filenames to be read/deleted for backward compatibility. IDs containing separators or traversal components never get a legacy fallback path.
Validation:
cargo +1.90.0 fmt --package cortex-snapshot --checkcargo +1.90.0 test -p cortex-snapshot path_components -- --nocapturecargo +1.90.0 test -p cortex-snapshotgit diff --check