Skip to content

fix(scrape): emit markdown table separators#320

Open
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-scrape-markdown-table-separator
Open

fix(scrape): emit markdown table separators#320
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-scrape-markdown-table-separator

Conversation

@OnlyYu1996
Copy link
Copy Markdown

Fixes PlatformNetwork/bounty-challenge#53179.

html_to_markdown() now renders HTML tables through a table-specific path that collects rows/cells and inserts a GitHub-flavored Markdown separator row after the first row. Cell content still goes through the existing markdown conversion path, then is flattened and pipe-escaped for table cells.

Validation:

  • cargo +1.90.0 fmt --package cortex-cli --check
  • isolated rustc +1.90.0 --test harness covering header separator output
  • git diff --check

Note: cargo +1.90.0 test -p cortex-cli test_html_to_markdown_table_includes_separator -- --nocapture is blocked on this Windows machine by the existing workspace aws-lc-sys MSVC build failure before cortex-cli tests run.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][v0.0.7] scrape --format markdown emits pipe rows without the Markdown header separator line

1 participant