Skip to content

fix(cli): preserve dotted agent references#321

Open
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-dotted-agent-reference-scan
Open

fix(cli): preserve dotted agent references#321
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-dotted-agent-reference-scan

Conversation

@OnlyYu1996
Copy link
Copy Markdown

Fixes PlatformNetwork/bounty-challenge#53243.

Summary

  • centralize the CLI @agent mention regex used by import/export
  • capture dotted agent names such as @acme.deploy as acme.deploy instead of truncating to acme
  • avoid swallowing a sentence-ending . after dotted mentions
  • add export/import regression coverage for dotted names

Validation

  • cargo +1.90.0 fmt --package cortex-cli --check
  • git diff --check
  • isolated rustc +1.90.0 --edition=2024 --test harness covering @acme.deploy, @foo.bar., and @my-agent

Targeted cargo +1.90.0 test -p cortex-cli ... is blocked locally on Windows before tests run by the existing aws-lc-sys MSVC C build failure (cl.exe exits while compiling aws-lc). The focused regex harness above validates the changed parsing behavior.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] cortex import @-mention scan truncates dotted agent names — "@foo.bar" is validated as "foo" only

1 participant