Skip to content

fix(cli): normalize stats model aggregation#322

Open
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-stats-model-case-normalization
Open

fix(cli): normalize stats model aggregation#322
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-stats-model-case-normalization

Conversation

@OnlyYu1996
Copy link
Copy Markdown

Fixes PlatformNetwork/bounty-challenge#53225.

Summary

  • normalize the stats by-model aggregation key case-insensitively
  • keep verbose output grouped under one canonical lower-case model ID such as gpt-4o
  • apply the same normalization to default pricing lookup so GPT-4O uses the gpt-4o pricing instead of the fallback
  • add regression coverage for mixed-case session files

Validation

  • cargo +1.90.0 fmt --package cortex-cli --check
  • git diff --check
  • isolated rustc +1.90.0 --edition=2024 --test harness covering case-normalized aggregation and case-insensitive GPT-4O pricing

Targeted cargo +1.90.0 test -p cortex-cli ... is blocked locally on Windows before tests run by the existing aws-lc-sys MSVC C build failure (cl.exe exits while compiling aws-lc). The focused harness above validates the changed aggregation and pricing behavior.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] cortex stats --verbose splits the same model into separate By Model rows when only letter case differs

1 participant