Skip to content

fix(uninstall): include cache log directory#329

Open
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-uninstall-cache-log-dir
Open

fix(uninstall): include cache log directory#329
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-uninstall-cache-log-dir

Conversation

@OnlyYu1996
Copy link
Copy Markdown

Fixes PlatformNetwork/bounty-challenge#53185.

Summary

  • Add uninstall collection for the cache-based logs directory used by cortex logs.
  • Make the removal safety check accept lowercase cortex paths so .cache/cortex/logs can actually be removed.
  • Add regression coverage for collecting existing/missing cache log directories and lowercase cortex path safety.

Validation

  • cargo +1.90.0 fmt --package cortex-cli --check
  • git diff --check

Targeted cargo +1.90.0 test -p cortex-cli test_collect_cache_log_items -- --nocapture is blocked in this Windows/MSVC environment before crate tests run by the existing �ws-lc-sys C build failure.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] cortex uninstall misses real CLI log files because it looks in ~/.cortex/logs while cortex logs uses the cache directory

1 participant