Skip to content

fix(logs): pluralize clear output#330

Open
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-logs-clear-singular-output
Open

fix(logs): pluralize clear output#330
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-logs-clear-singular-output

Conversation

@OnlyYu1996
Copy link
Copy Markdown

Fixes PlatformNetwork/bounty-challenge#43648.

Summary

  • Replace the log file(s) placeholder in logs --clear success output with a proper singular/plural label.
  • Add regression coverage for the log file count label.

Validation

  • cargo +1.90.0 fmt --package cortex-cli --check
  • git diff --check

Targeted cargo +1.90.0 test -p cortex-cli test_log_file_label_singular_and_plural -- --nocapture is blocked in this Windows/MSVC environment before crate tests run by the existing �ws-lc-sys C build failure.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] cortex logs --clear always prints 'log file(s)' when exactly one file is deleted

1 participant