Skip to content

fix(stats): support provider-prefixed pricing env keys#333

Open
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-pricing-provider-model-env
Open

fix(stats): support provider-prefixed pricing env keys#333
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-pricing-provider-model-env

Conversation

@OnlyYu1996
Copy link
Copy Markdown

Fixes PlatformNetwork/bounty-challenge#53203.

Summary

  • Add a shell-safe double-underscore encoding for provider-prefixed pricing env keys.
  • Preserve the existing single-underscore to hyphen mapping.
  • Add regression coverage for provider/model IDs and legacy model IDs.

Validation

  • cargo +1.90.0 fmt --package cortex-cli --check
  • git diff --check

Targeted cargo +1.90.0 test -p cortex-cli test_pricing_env_model_name -- --nocapture is blocked in this Windows/MSVC environment before crate tests run by the existing aws-lc-sys C build failure.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][v0.0.7] CORTEX_PRICING_* env keys cannot represent provider-prefixed models (slash in model id)

1 participant