Skip to content

fix(stats): support provider-prefixed pricing env keys #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OnlyYu1996 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(stats): support provider-prefixed pricing env keys #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion src/cortex-cli/src/stats_cmd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,11 @@ fn load_custom_pricing() -> std::collections::HashMap<String, ModelPricing> {
// Try to load from environment variables in format:
// CORTEX_PRICING_<MODEL>=<input_price>,<output_price>
// Example: CORTEX_PRICING_GPT4O=2.5,10.0
// Use double underscore to encode provider-prefixed model IDs:
// CORTEX_PRICING_ANTHROPIC__CLAUDE_3_5_SONNET=3.0,15.0
for (key, value) in std::env::vars() {
if let Some(model_suffix) = key.strip_prefix("CORTEX_PRICING_") {
let model_name = model_suffix.to_lowercase().replace('_', "-");
let model_name = pricing_env_model_name(model_suffix);
let parts: Vec<&str> = value.split(',').collect();
if parts.len() == 2
&& let (Ok(input), Ok(output)) = (
Expand All @@ -142,6 +144,14 @@ fn load_custom_pricing() -> std::collections::HashMap<String, ModelPricing> {
custom
}

fn pricing_env_model_name(model_suffix: &str) -> String {
model_suffix
.to_lowercase()
.replace("__", "\0")
.replace('_', "-")
.replace('\0', "/")
}

impl StatsCli {
/// Run the stats command.
pub async fn run(self) -> Result<()> {
Expand Down Expand Up @@ -735,6 +745,27 @@ mod tests {
assert!((cost - 12.5).abs() < 0.001);
}

#[test]
fn test_pricing_env_model_name_supports_provider_prefixed_models() {
assert_eq!(
pricing_env_model_name("ANTHROPIC__CLAUDE_3_5_SONNET"),
"anthropic/claude-3-5-sonnet"
);
assert_eq!(
pricing_env_model_name("OPENAI__GPT_4O_MINI"),
"openai/gpt-4o-mini"
);
}

#[test]
fn test_pricing_env_model_name_preserves_legacy_underscore_mapping() {
assert_eq!(pricing_env_model_name("GPT_4O_MINI"), "gpt-4o-mini");
assert_eq!(
pricing_env_model_name("CLAUDE_3_5_HAIKU"),
"claude-3-5-haiku"
);
}

#[test]
fn test_validate_days_range() {
// Valid values
Expand Down