Skip to content

fix(cli): keep dag validate success output on stdout#341

Open
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-dag-validate-verbose-stdout
Open

fix(cli): keep dag validate success output on stdout#341
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-dag-validate-verbose-stdout

Conversation

@OnlyYu1996
Copy link
Copy Markdown

Summary

  • route the normal dag validate success line through the stdout success helper
  • keep verbose execution order on stdout, so dag validate --verbose no longer splits normal success output across stdout and stderr
  • fix a stale agent command test import that blocks cortex-cli tests on current main

Fixes PlatformNetwork/bounty-challenge#53108.

Validation

  • cargo +stable fmt --package cortex-cli --check
  • cargo +stable test --package cortex-cli dag_cmd::tests
  • cargo +stable check --package cortex-cli --lib
  • direct target/debug/Cortex.exe dag validate --verbose --file <dag.json> 1>stdout 2>stderr smoke: success line and execution order in stdout, stderr empty
  • git diff --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] cortex dag validate --verbose splits normal success output across stderr and stdout

1 participant