fix: prevent UTF-8 char boundary panics in agent handlers#344
Open
darioandyoshi-tech wants to merge 1 commit into
Open
fix: prevent UTF-8 char boundary panics in agent handlers#344darioandyoshi-tech wants to merge 1 commit into
darioandyoshi-tech wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple panics caused by unsafe byte-slicing of strings that may contain multi-byte UTF-8 characters.
The fix replaces byte-based slicing with a UTF-8 aware approach using .chars().take().collect() to ensure truncation occurs on valid character boundaries.
Fixes:
Reference: PlatformNetwork/bounty-challenge#3920