Skip to content

fix(tui): pluralize sessions command category#345

Open
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-command-category-sessions-label
Open

fix(tui): pluralize sessions command category#345
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-command-category-sessions-label

Conversation

@OnlyYu1996
Copy link
Copy Markdown

Fixes PlatformNetwork/bounty-challenge#53114.

Changes:

  • Uses Sessions for command-category display names in the TUI command system.
  • Updates the command modal and command card category labels to match palette session grouping.
  • Leaves singular Session names intact where they refer to one specific view/session, not a grouping category.
  • Updates regression assertions for the affected category labels.

Validation:

  • rustfmt +stable --edition 2024 --check src/cortex-tui/src/commands/types.rs src/cortex-tui/src/modal/commands.rs src/cortex-tui/src/cards/commands.rs
  • cargo +stable test --package cortex-tui test_command_category_display_name -- --nocapture
  • cargo +stable check --package cortex-tui --lib
  • git diff --check

Note: cargo +stable fmt --package cortex-tui --check is blocked on current main by unrelated pre-existing formatting diffs in src/cortex-common/src/lib.rs and src/cortex-tui/src/question.rs; the files changed here pass rustfmt directly.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][v0.0.7] Command palette uses singular Session label where other palette paths use Sessions

1 participant