fix(cli): align mcp existing server advice#348
Open
OnlyYu1996 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes inconsistent advice when
cortex mcp renametargets an existing MCP server.Bounty issue: PlatformNetwork/bounty-challenge#53102
Changes:
mcp addandmcp rename.mcp rename --force/-fso the advice points to a working overwrite path.cortex-clitests/checks to pass.Validation:
cargo +stable fmt --package cortex-cli --checkcargo +stable test --package cortex-cli mcp_cmd::types::tests::test_mcp_cli_command_aliases_are_valid -- --nocapturecargo +stable test --package cortex-cli mcp_cmd:: -- --nocapturecargo +stable check --package cortex-cli --libcargo +stable build --package cortex-cli --bin Cortexrename --forcegit diff --check