fix(scrape): preserve ordered list markers#357
Open
OnlyYu1996 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<li>items under<ol>with numbered Markdown markers instead of unordered-bullets<ul>items, including nested unordered lists inside ordered listsstartattribute when numbering begins above 1cortex-clitest harness compilesFixes PlatformNetwork/bounty-challenge#53127.
Validation
cargo fmt --package cortex-cli --checkcargo test --package cortex-cli test_html_to_markdown_ordered_lists -- --nocapturecargo test --package cortex-cli scrape_cmd::tests -- --nocapturecargo check --package cortex-cli --libgit diff --checkNotes: validation passes with existing warnings in
src/cortex-tui/src/external_editor.rsandsrc/cortex-cli/src/utils/notification.rsthat are unrelated to this patch.