Skip to content

fix(scrape): preserve ordered list markers#357

Open
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:codex/fix-scrape-ordered-lists
Open

fix(scrape): preserve ordered list markers#357
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:codex/fix-scrape-ordered-lists

Conversation

@OnlyYu1996
Copy link
Copy Markdown

Summary

  • render <li> items under <ol> with numbered Markdown markers instead of unordered - bullets
  • preserve unordered markers for <ul> items, including nested unordered lists inside ordered lists
  • honor the ordered list start attribute when numbering begins above 1
  • fix a stale test import so the current cortex-cli test harness compiles

Fixes PlatformNetwork/bounty-challenge#53127.

Validation

  • cargo fmt --package cortex-cli --check
  • cargo test --package cortex-cli test_html_to_markdown_ordered_lists -- --nocapture
  • cargo test --package cortex-cli scrape_cmd::tests -- --nocapture
  • cargo check --package cortex-cli --lib
  • git diff --check

Notes: validation passes with existing warnings in src/cortex-tui/src/external_editor.rs and src/cortex-cli/src/utils/notification.rs that are unrelated to this patch.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][v0.0.7] scrape --format markdown renders <ol> items as unordered - bullets

1 participant