Skip to content

fix(run): include max tokens in dry-run estimates#359

Open
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:codex/fix-run-max-tokens-dry-run
Open

fix(run): include max tokens in dry-run estimates#359
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:codex/fix-run-max-tokens-dry-run

Conversation

@OnlyYu1996
Copy link
Copy Markdown

Summary

  • Reject cortex run --max-tokens 0 at CLI parse time.
  • Include max_response and total_with_max_response in dry-run JSON estimates.
  • Print Max response and Input + response in text dry-run output when --max-tokens is provided.
  • Update a stale test import so the package test target compiles on current main.

Fixes PlatformNetwork/bounty-challenge#53234

Verification

  • cargo fmt --package cortex-cli --check
  • cargo test --package cortex-cli run_cmd::execution::tests -- --nocapture
  • cargo check --package cortex-cli --lib
  • git diff --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant