Skip to content

Fix plugin list JSON error for conflicting filters#362

Open
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:codex/fix-plugin-list-json-conflict
Open

Fix plugin list JSON error for conflicting filters#362
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:codex/fix-plugin-list-json-conflict

Conversation

@OnlyYu1996
Copy link
Copy Markdown

Summary

  • emit a structured JSON error when cortex plugin list --json --enabled --disabled is used
  • keep the non-JSON conflicting filter path unchanged
  • fix a stale test import so cortex-cli tests compile on current main

Fixes PlatformNetwork/bounty-challenge#52983

Verification

  • cargo fmt --package cortex-cli --check
  • cargo test --package cortex-cli plugin_cmd::tests::test_plugin_list_filter_conflict_error_serializes_as_json -- --nocapture
  • cargo test --package cortex-cli plugin_cmd::tests -- --nocapture
  • cargo check --package cortex-cli --lib
  • git diff --check
  • cargo run --package cortex-cli --bin Cortex -- plugin list --json --enabled --disabled

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] plugin list --json returns a plain-text error instead of JSON when --enabled and --disabled are used together

1 participant