Skip to content

Fix plugin new cd hint for custom output dirs#363

Open
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:codex/fix-plugin-new-output-cd
Open

Fix plugin new cd hint for custom output dirs#363
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:codex/fix-plugin-new-output-cd

Conversation

@OnlyYu1996
Copy link
Copy Markdown

Summary

  • print the actual created plugin directory in the plugin new next-step cd hint
  • keep default output behavior unchanged while making custom --output directories copy-pasteable
  • fix a stale test import so cortex-cli tests compile on current main

Fixes PlatformNetwork/bounty-challenge#53131

Verification

  • cargo fmt --package cortex-cli --check
  • cargo test --package cortex-cli plugin_cmd::tests::test_plugin_new_cd_target_uses_created_directory -- --nocapture
  • cargo test --package cortex-cli plugin_cmd::tests -- --nocapture
  • cargo check --package cortex-cli --lib
  • git diff --check
  • cargo run --package cortex-cli --bin Cortex -- plugin new sample-output-plugin --output /tmp/.../out-plugins --author Codex

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] After cortex plugin new -o <dir>, the printed “change directory” line ignores the parent chosen via --output

1 participant