Skip to content

Fix dag validate singular task output#369

Open
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:codex/fix-dag-validate-singular-task
Open

Fix dag validate singular task output#369
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:codex/fix-dag-validate-singular-task

Conversation

@OnlyYu1996
Copy link
Copy Markdown

Summary

  • use singular task in cortex dag validate success output when the DAG has exactly one task
  • keep plural tasks for all other counts
  • add focused regression coverage for the task-count label
  • fix a stale test import so the affected crate tests compile on current main

Fixes PlatformNetwork/bounty-challenge#43808

Tests

  • cargo fmt --package cortex-cli --check
  • cargo test --package cortex-cli dag_cmd::tests::test_dag_validate_task_count_label_uses_singular_for_one_task -- --nocapture
  • cargo test --package cortex-cli dag_cmd::tests -- --nocapture
  • cargo check --package cortex-cli --lib
  • cargo run --package cortex-cli --bin Cortex -- dag validate --file /tmp/.../single-task.yaml
  • git diff --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] cortex dag validate displays "DAG is valid (1 tasks, no cycles detected)" — singular/plural mismatch in validation output

1 participant