From 6d4931f1fd7d5d1f2c49d4f7bb81ffcca76be021 Mon Sep 17 00:00:00 2001 From: onlyyu1996 <1158673577@qq.com> Date: Mon, 18 May 2026 16:55:45 +0800 Subject: [PATCH] Fix dag create singular task output --- src/cortex-cli/src/agent_cmd/tests.rs | 5 ++--- src/cortex-cli/src/dag_cmd/commands.rs | 14 +++++++++++++- src/cortex-cli/src/dag_cmd/tests.rs | 7 +++++++ 3 files changed, 22 insertions(+), 4 deletions(-) diff --git a/src/cortex-cli/src/agent_cmd/tests.rs b/src/cortex-cli/src/agent_cmd/tests.rs index e2ff07f9f..18f7ba753 100644 --- a/src/cortex-cli/src/agent_cmd/tests.rs +++ b/src/cortex-cli/src/agent_cmd/tests.rs @@ -3,10 +3,9 @@ #[cfg(test)] mod tests { use crate::agent_cmd::cli::{CopyArgs, ExportArgs}; - use crate::agent_cmd::loader::{ - load_builtin_agents, parse_frontmatter, read_file_with_encoding, - }; + use crate::agent_cmd::loader::{load_builtin_agents, parse_frontmatter}; use crate::agent_cmd::types::AgentMode; + use crate::utils::file::read_file_with_encoding; #[test] fn test_read_file_with_utf8() { diff --git a/src/cortex-cli/src/dag_cmd/commands.rs b/src/cortex-cli/src/dag_cmd/commands.rs index dc20992fc..b0535c252 100644 --- a/src/cortex-cli/src/dag_cmd/commands.rs +++ b/src/cortex-cli/src/dag_cmd/commands.rs @@ -18,6 +18,14 @@ use super::helpers::{ use super::scheduler::DagScheduler; use super::types::{DagOutputFormat, ExecutionStrategy}; +pub(super) fn task_count_label(count: usize) -> String { + if count == 1 { + "1 task".to_string() + } else { + format!("{} tasks", count) + } +} + /// Create a DAG from specification. pub async fn run_create(args: DagCreateArgs) -> Result<()> { let spec = load_spec(&args.file)?; @@ -49,7 +57,11 @@ pub async fn run_create(args: DagCreateArgs) -> Result<()> { match args.format { DagOutputFormat::Text => { - print_success(&format!("✓ Created DAG '{}' with {} tasks", id, dag.len())); + print_success(&format!( + "✓ Created DAG '{}' with {}", + id, + task_count_label(dag.len()) + )); println!(); print_dag_summary(&dag); } diff --git a/src/cortex-cli/src/dag_cmd/tests.rs b/src/cortex-cli/src/dag_cmd/tests.rs index a2bc60cb4..07c8c23a0 100644 --- a/src/cortex-cli/src/dag_cmd/tests.rs +++ b/src/cortex-cli/src/dag_cmd/tests.rs @@ -5,6 +5,7 @@ use super::types::{DagSpecInput, TaskSpecInput}; use cortex_agents::task::{DagHydrator, Task, TaskId, TaskSpec}; use std::collections::HashMap; +use super::commands::task_count_label; use super::executor::TaskExecutor; #[test] @@ -78,6 +79,12 @@ fn test_dag_creation_with_cycle_detection() { assert!(result.is_err()); } +#[test] +fn test_dag_create_task_count_label_uses_singular_for_one_task() { + assert_eq!(task_count_label(1), "1 task"); + assert_eq!(task_count_label(2), "2 tasks"); +} + #[tokio::test] async fn test_task_executor() { let executor = TaskExecutor::new(30, false);