Skip to content

Clarify agent list hidden counts#375

Closed
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:fix-agent-list-hidden-footer
Closed

Clarify agent list hidden counts#375
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:fix-agent-list-hidden-footer

Conversation

@GreyforgeLabs
Copy link
Copy Markdown

Summary

  • split agent list filtering into a matching population and visible rows
  • count hidden agents within the same filtered population used for role totals
  • update the footer to show Showing visible of total agents when hidden agents are omitted

Fixes PlatformNetwork/bounty-challenge#53156

Tests

  • cargo fmt --package cortex-cli --check
  • git diff --check
  • cargo check -p cortex-cli --no-default-features --features cortex-tui
  • cargo run -p cortex-cli --no-default-features --features cortex-tui --bin Cortex -- agent list | tail -n 4
  • cargo run -p cortex-cli --no-default-features --features cortex-tui --bin Cortex -- agent list --all | tail -n 4

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] cortex agent list footer mixes global “hidden” math with role counts that only cover visible rows

1 participant