Skip to content

Validate snapshot storage IDs#384

Open
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:fix-snapshot-storage-id-validation
Open

Validate snapshot storage IDs#384
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:fix-snapshot-storage-id-validation

Conversation

@GreyforgeLabs
Copy link
Copy Markdown

Summary

  • Reject snapshot IDs and session IDs that are not single filename segments before building snapshot metadata paths.
  • Propagate validation errors through snapshot and revert-history save/load/delete paths.
  • Add coverage for snapshot ID traversal, session-history traversal, accepted UUID-like IDs, and rejected path segments.

Fixes PlatformNetwork/bounty-challenge#53119.

Validation

  • cargo test -p cortex-snapshot
  • cargo check -p cortex-snapshot
  • cargo fmt --package cortex-snapshot --check
  • git diff --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant