Skip to content

Respect CORTEX_HOME for ACP agent lookup#385

Open
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:fix-acp-agent-cortex-home
Open

Respect CORTEX_HOME for ACP agent lookup#385
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:fix-acp-agent-cortex-home

Conversation

@GreyforgeLabs
Copy link
Copy Markdown

Summary

  • Resolve ACP agent lookup through Cortex's existing home resolver instead of hardcoding ~/.cortex.
  • Keep the current early --agent validation behavior while honoring CORTEX_HOME.
  • Add a binary integration regression that creates an agent under a temporary CORTEX_HOME and verifies cortex acp --agent does not fail with Agent not found.

Fixes PlatformNetwork/bounty-challenge#51939.

Validation

  • cargo test -p cortex-cli --test acp_cortex_home --no-default-features --features cortex-tui -- --nocapture
  • cargo check -p cortex-cli --no-default-features --features cortex-tui
  • cargo fmt --package cortex-cli --check
  • git diff --check

Note: cargo test -p cortex-cli acp_cmd::tests::test_acp_agent_lookup_uses_cortex_home -- --nocapture was attempted first and hit the existing default-feature alsa.pc system dependency in this environment before the test was moved to the binary integration suite.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] cortex acp --agent ignores CORTEX_HOME — always scans ~/.cortex for agents

1 participant